Skip to content
Snippets Groups Projects
  1. Sep 13, 2019
  2. Jan 24, 2019
    • Jacopo's avatar
      Adds milestone search · 22eb2e4c
      Jacopo authored
      Adds to search ILIKE search for milestones title in:
        - Milestones dashboard
        - Group milestones page
        - Project milestones page
      22eb2e4c
  3. Dec 20, 2018
  4. Oct 16, 2018
  5. Sep 23, 2018
    • gfyoung's avatar
      Enable more frozen string in app/controllers/ · be42c050
      gfyoung authored
      Enables frozen string for the following:
      
      * app/controllers/dashboard/**/*.rb
      * app/controllers/explore/**/*.rb
      * app/controllers/google_api/**/*.rb
      * app/controllers/groups/**/*.rb
      * app/controllers/import/**/*.rb
      * app/controllers/instance_statistics/**/*.rb
      * app/controllers/ldap/**/*.rb
      * app/controllers/oauth/**/*.rb
      * app/controllers/profiles/**/*.rb
      
      Partially addresses #47424.
      be42c050
  6. Aug 06, 2018
  7. Jun 04, 2018
  8. Apr 05, 2018
  9. Jan 17, 2018
  10. Nov 07, 2017
  11. Aug 29, 2017
  12. Jul 07, 2017
  13. Jun 26, 2017
  14. Apr 26, 2017
  15. Mar 10, 2017
  16. Jan 06, 2017
  17. Nov 23, 2016
  18. Nov 10, 2016
  19. Apr 07, 2016
  20. Apr 05, 2016
  21. Mar 23, 2016
  22. Mar 20, 2016
  23. Dec 05, 2015
    • Stan Hu's avatar
      Fix Error 500 when creating global milestones with Unicode characters · d800a949
      Stan Hu authored
      Two issues:
      
      1. The constraints in the resources were incorrect. Here's what it was before:
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      In this case, id is actually the title of the milestone, which can be anything at the moment.
      
      After:
      
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
      
      ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
      
      This change uses the babosa library to create a better slug, which surprisingly
      isn't actually used by the global milestone controllers. Instead, they use the
      title passed as a query string for some reason.
      
      Closes https://github.com/gitlabhq/gitlabhq/issues/9881
      
      Fix constraints
      d800a949
  24. Nov 16, 2015
  25. Apr 30, 2015
  26. Apr 20, 2015
  27. Apr 14, 2015
  28. Mar 12, 2015
  29. Mar 03, 2015
  30. Jul 04, 2014
  31. Jun 30, 2014
Loading