Denys Mishunov authored 5 years ago and Filipa Lacerda committed 5 years ago

Resolves a regression caused by https://bit.ly/2k1GozA

Creating a MR from an issue using a tag as ref correctly creates the
source branch starting from the tag.

- Show if user can_resolve all of the notes

The Sidekiq job `RemoveExpiredMembersWorker` was failing to run in
production because it was hitting statement timeouts because it was
scanning all rows in order. On staging, where it used to scan 4 million
rows, adding an index brought this down to only a few hundred rows.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/67286

to ensure any markdown generated before the asset
proxy default was corrected is re-generated

Replace 'chronic_duration' to 'gitlab_chronic_duration', to make
relevant method calls thread-safe.

Refactor project_edit.js to be reusable for this purpose

Closes #64799

This change updates the text of the pipeline widget that appears on the
merge request page. The text has been made more consistent between
different types of pipelines; this makes the front-end implementation
simpler and more maintainable.  In addition, the type of pipeline is
(i.e. regular pipeline, merge request pipeline, detached pipeline)
included in the text, making this type more obvious to the end user.

Some information has been removed from the widget as part of this
change; however, any information that was removed already appears
elsewhere on the merge request page.

In the Merge Request view, under pipelines tab
the user can see a run pipeline button

Adds axios post request to button click

Adds the logic to handle the user click,
refresh the table and disable the button while thee
request is being made

Updates UI for desktop and mobile

Adds specs
Regenerates potfile

Follow-up after review

Uses .finally to avoid code repetition

Winnie Hellmann authored 5 years ago and Paul Slaughter committed 5 years ago

Fixes https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32400

For zero-downtime deployed in a mixed code environment between 12.2 and
12.3, the branch and tag name cache is incorrectly invalidated - a push
to an old machine will not clear the redis set version of the cache on
the new machine.

This commit ensures that, in 12.3, both set and non-set versions of the
cache are invalidated, but does not write or consult the set version of
the cache. . In 12.4, it will be safe to switch branch and tag names to
the redis set cache both it and the legacy cache will be invalidated
appropriately in such a mixed code environment.

This delays the full implementation of the feature by one release, but
in the absence of a credible feature-flagging strategy, and amidst an
abundance of caution about the effects of too-eager cache expiration, I
believe this is the best approach available to us.

- Avoid N+1 queries for authors and comment counts
- Avoid an additional snippet existence query

This reverts commit c6ccc07f.

It consists of two parts:

1. Redirecting users to the configured external storage
1. Allowing the external storage to request the static object(s)
   on behalf of the user by means of specific tokens

Part of https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6829

In case the source and the target project are the same, the
source branch is the default branch, and the target branch
is not present, we will avoid prefilling the target branch
with the repository default branch. Letting the user decide.

On our dev instance, /admin/applications as not loading because:

1. There was an unindexed query by `application_id`.
2. There was an expensive query that attempted to load 1 million
   unique entries via ActiveRecord just to find the unique count.

We fix the first issue by adding an index for that column.

We fix the second issue with a simple SELECT COUNT(DISTINCT
resource_owner_id) SQL query.

In addition, we add pagination to avoid loading more than 20
applications at once.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/67228

Utilize `json_fields` to expose fields via
`Service#as_json(only: json_fields)`.

Add MR to changelog entry
Adjust to give margin bottom to details instead of last-child
Remove trailing whitespace

The carets will function as a button that will allow the panels
from the monitoring dashboard to collapse and show panels

Add changelog

ActiveModel::Serialization is simple in that it recursively calls
`as_json` on each object to serialize everything. However, for a model
like a Project, this can generate a query for every single association,
which can add up to tens of thousands of queries and lead to memory
bloat.

To improve this, we can do several things:

1. We use `tree:` and `preload:` to automatically generate
   a list of all preloads that could be used to serialize
   objects in bulk.

2. We observe that a single project has many issues, merge requests,
   etc. Instead of serializing everything at once, which could lead to
   database timeouts and high memory usage, we take each top-level
   association and serialize the data in batches.

For example, we serialize the first 100 issues and preload all of
their associated events, notes, etc. before moving onto the next
batch. When we're done, we serialize merge requests in the same way.
We repeat this pattern for the remaining associations specified in
import_export.yml.

Lowering the limit when performing search from 1001 to 101.
This will allow us to speed this process.

Manoj M J authored 5 years ago and Ash McKenzie committed 5 years ago

This change implements Application
Statistics API

Just replace RSA.new with PKey.read

Marcel Amirault authored 5 years ago and Paul Slaughter committed 5 years ago

Add missing shortcuts, remove shortcuts that don't exist,
and reorder as needed

Expose id field in the serializer in order
to store comments content in the localStorage
under the correct key