rails_helper.rb's only logic was to require
spec_helper.rb.

David Wilkins authored 5 years ago and Ash McKenzie committed 5 years ago

- Closes #60024

- Change PrometheusClient.new to accept a base url instead of an
  already created RestClient

- Use Gitlab::HTTP in PrometheusClient instead of creating RestClient
  in PrometheusService

- Move http_options from PrometheusService to
  PrometheusClient (follow_redirects: false)

- ensure that base urls don't have the trailing slash

- Created a `PrometheusClient#url` method that might not be strictly
  required

- Change rescued exceptions from RestClient::* to
  HTTParty::ResponseError where possible and StandardError for the
  rest

In order to not miss any errors since we are not checking the return
value of update

Basically does the reverse of after_transition to :installed.

Add specs

Only prometheus can be uninstalled atm, the rest will be dealt with
later.

Presumption is that new application types will have uninstallation
implmemented at the same time.

Thong Kuah authored 5 years ago and James Lopez committed 5 years ago

- rewords examples starting with 'should'
- rewords examples starting with 'it'

Note: I had to manually fixup "onlies" to "only"

Adds `# frozen_string_literal: true` to spec/models ruby files

- Adds to specs the case where apps are also updated
- Rename scope calls on Gitlab::UsageData and Clusters::Cluster
- Removes a duplicated spec

This could be potentially useful to all cluster applications.

Address followup issue https://gitlab.com/gitlab-org/gitlab-ce/issues/56524

All applications except for Jupyter have the same #set_initial_status,
so create a new shared example which we include in all application specs
except for juptyer_spec. Juptyer specs already have specs for it's
version of #set_initial_status

This makes this consistent with :updated. And also avoids a potential
issue where an install errors which means that that the recorded version
won't necessarily reflect the version that is actually installed.

Port from EE generic upgrade related functionality used to upgrade Helm
applications

Remove memoization which could be incorrect

It looks like we are memoizing without regard to the method's argument
so this could result in an incorrect upgrade_command

Remove `const_get` indirection now we are no longer in EE

Many changes were also made to tests that expected this to default to
false.

Before this commit updating Prometheus (e.g. adding alerts) made it
"updated" therefore not installed.

This makes this consistent with the specs for other applications as
well as fixing a bug in the 'application failed to install previously'
spec

Fix up VERSION for each of the applications
* There is no 0.0.1 helm version for jupyterhub. Use the latest version instead
* `:nginx` is not a valid chart version. Lock the ingress application GitLab installs to the latest chart version.
* Use the latest gitlab-runner chart to prevent GitLab installing older versions when users have been installing the lastest version

Always install from the VERSION and not the database `version` column.
This should fix cases like https://gitlab.com/gitlab-org/gitlab-ee/issues/6795 in
the instances where an install command failed previously, which locked the version
in the database to an older version.

Also, ensure that the version column is updated to the version we are
installing.

Add specs to show how previously failed appplications will be handled when the helm installation is run again

Add changelog entry

This reverts merge request !20801

This is refactoring in the lead up to passing mutual TLS certs for helm applications. As such we expect all applications to need config files so we can remove the logic about which applications need and do not need this (ie `#config_map?`).