Adds specs for testing the new behavior of specifying a pipeline when
POSTing a status.

Gaetan Semet authored 5 years ago and Matija Čupić committed 5 years ago

This allows user to specify the pipeline ID
when several pipelines has been triggered
on the same branch and commit.

Signed-off-by: Gaetan Semet <gaetan.semet@renault.com>

It also renames the API::PROJECT_ENDPOINT_REQUIREMENTS constant to
API::NAMESPACE_OR_PROJECT_REQUIREMENTS

Partially addresses #47424.

Had to make changes to spec files because
stubbing methods on frozen objects is a mess
in RSpec and leads to failures:

https://github.com/rspec/rspec-mocks/issues/1190

This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.

Currently we still need to run EnsureStageService within a transaction,
because when it runs within in a transaction we are going to stick to
the primary database when using database load balancing. Extracting this
out of the transaction makes it possible to hit into problems with
replication lag in pipeline commit status API, which can cause a lot of
trouble.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Passing different optional attributes in case of updating an existing
commit status should not create a new commit status with the same name.

If validation errors are present, include validation errors in the
commit status API payload, instead of depending on state machine errors
caused by invalid record.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

This reverts commit 3e991230.

# Conflicts:
#	app/models/project.rb