Skip to content
Snippets Groups Projects
  1. Jan 24, 2018
  2. Jan 22, 2018
  3. Jan 19, 2018
  4. Jan 18, 2018
  5. Jan 17, 2018
    • Mario de la Ossa's avatar
      Initial work to add notification reason to emails · 23a20c20
      Mario de la Ossa authored
      Adds `#build_notification_recipients` to `NotificationRecipientService`
      that returns the `NotificationRecipient` objects in order to be able to
      access the new attribute `reason`.
      
      This new attribute is used in the different notifier methods in order to
      add the reason as a header: `X-GitLab-NotificationReason`.
      
      Only the reason with the most priority gets sent.
      Unverified
      23a20c20
    • Robert Speicher's avatar
      Merge branch 'jej/fix-disabled-oauth-access-10-3' into 'security-10-3' · 4493ec08
      Robert Speicher authored
      [10.3] Prevent login with disabled OAuth providers
      
      See merge request gitlab/gitlabhq!2296
      
      (cherry picked from commit 4936650427ffc88e6ee927aedbb2c724d24b094c)
      
      a0f9d222 Prevents login with disabled OAuth providers
      4493ec08
    • Sean McGivern's avatar
      Merge branch '41567-projectfix' into 'security-10-3' · 3fc0564a
      Sean McGivern authored
      check project access on MR create
      
      See merge request gitlab/gitlabhq!2273
      
      (cherry picked from commit 1fe2325d6ef2bced4c5e97b57691c894f38b2834)
      
      43e85f49 check project access on MR create
      3fc0564a
    • Stan Hu's avatar
      Merge branch... · 0424801e
      Stan Hu authored
      Merge branch 'security-10-3-do-not-expose-passwords-or-tokens-in-service-integrations-api' into 'security-10-3'
      
      Filter out sensitive fields from the project services API
      
      See merge request gitlab/gitlabhq!2281
      
      (cherry picked from commit 476f2576444632f2a9a61b4cead9c1077f2c81d7)
      
      2bcbbda0 Filter out sensitive fields from the project services API
      0424801e
  6. Jan 15, 2018
  7. Jan 11, 2018
  8. Jan 05, 2018
  9. Jan 04, 2018
  10. Jan 03, 2018
  11. Dec 22, 2017
  12. Dec 21, 2017
  13. Dec 19, 2017
    • Robert Speicher's avatar
      Only include the user's ID in the time_spent command's update hash · 3e4b45fc
      Robert Speicher authored
      Previously, this would include the entire User record in the update
      hash, which was rendered in the response using `to_json`, erroneously
      exposing every attribute of that record, including their (now removed)
      private token.
      
      Now we only include the user ID, and perform the lookup on-demand.
      3e4b45fc
  14. Dec 16, 2017
  15. Dec 15, 2017
    • Sean McGivern's avatar
      Don't use Markdown cache for stubbed settings in specs · 10885edf
      Sean McGivern authored
      The ApplicationSetting model uses the CacheMarkdownField concern, which updates
      the cached HTML when the field is updated in the database. However, in specs,
      when we want to test conditions using ApplicationSetting, we stub it, because
      this is accessed in different ways throughout the application.
      
      This means that if a spec runs that caches one of the Markdown fields, and a
      later spec uses `stub_application_setting` to set the raw value of that field,
      the cached value was still the original one. We can work around this by ignoring
      the Markdown cache in contexts where we're using `stub_application_setting`.
      
      We could be smarter, and only do this on the Markdown fields of the model, but
      this is probably fine.
      10885edf
  16. Dec 14, 2017
  17. Dec 08, 2017
    • Bob Van Landuyt's avatar
      Move the circuitbreaker check out in a separate process · f1ae1e39
      Bob Van Landuyt authored
      Moving the check out of the general requests, makes sure we don't have
      any slowdown in the regular requests.
      
      To keep the process performing this checks small, the check is still
      performed inside a unicorn. But that is called from a process running
      on the same server.
      
      Because the checks are now done outside normal request, we can have a
      simpler failure strategy:
      
      The check is now performed in the background every
      `circuitbreaker_check_interval`. Failures are logged in redis. The
      failures are reset when the check succeeds. Per check we will try
      `circuitbreaker_access_retries` times within
      `circuitbreaker_storage_timeout` seconds.
      
      When the number of failures exceeds
      `circuitbreaker_failure_count_threshold`, we will block access to the
      storage.
      
      After `failure_reset_time` of no checks, we will clear the stored
      failures. This could happen when the process that performs the checks
      is not running.
      f1ae1e39
  18. Dec 07, 2017
  19. Dec 06, 2017
    • Takuya Noguchi's avatar
      Rename GKE as Kubernetes Engine · c21b488e
      Takuya Noguchi authored
      c21b488e
    • Michael Kozono's avatar
      Fix specs after rebase · 03cba8c0
      Michael Kozono authored
      Later migrations added fields to the EE DB which were used by factories which were used in these specs.
      
      And in CE on MySQL, a single appearance row is enforced.
      
      The migration and migration specs should not depend on the codebase staying the same.
      03cba8c0
    • Yorick Peterse's avatar
      Throttle the number of UPDATEs triggered by touch · 856447cc
      Yorick Peterse authored
      This throttles the number of UPDATE queries that can be triggered by
      calling "touch" on a Note, Issue, or MergeRequest. For Note objects we
      also take care of updating the associated "noteable" relation in a
      smarter way than Rails does by default.
      Verified
      856447cc
  20. Dec 04, 2017
  21. Dec 03, 2017
  22. Dec 01, 2017
Loading