- Feb 16, 2018
-
-
ABaldwinHunter authored
It seems like this value is already nil
-
James Lopez authored
-
Dylan Griffith authored
-
- Feb 15, 2018
-
-
Francisco Javier López authored
-
Douwe Maan authored
-
-
James Edwards-Jones authored
-
- Feb 14, 2018
-
-
Turo Soisenniemi authored
Without setting outfilesuffix Asciidoctor defaults to .html. When .html is used, inter-document cross references do not work in Gitlab's repository / file renderer. See more information from http://asciidoctor.org/docs/user-manual/#navigating-between-source-files and http://asciidoctor.org/docs/user-manual/#inter-document-cross-references
-
James Lopez authored
-
James Lopez authored
-
Michael Kozono authored
And use :migration tag to use deletion strategy, and to avoid caching tables, and to lock into a particular schema. Attempting to fix intermittent spec errors `PG::UndefinedTable: ERROR: relation "public.untracked_files_for_uploads" does not exist`.
-
George Tsiolis authored
-
Robert Schilling authored
-
Jarka Kadlecova authored
-
- Feb 13, 2018
-
-
Yorick Peterse authored
Using Sentry, while useful, poses two problems you have to choose from: 1. All errors are reported separately, making it easy to create issues but also making it next to impossible to see other errors (due to the sheer volume of threshold errors). 2. Errors can be grouped or merged together, reducing the noise. This however also means it's (as far as I can tell) much harder to automatically create GitLab issues from Sentry for the offending controllers. Since both solutions are terrible I decided to go with a third option: not using Sentry for this at all. Instead we'll investigate using Prometheus alerts and Grafana dashboards for this, which has the added benefit of being able to more accurately measure the behaviour over time. Note that throwing errors in test environments is still enabled, and whitelisting is still necessary to prevent that from happening (and that in turn still requires that developers create issues).
-
Drew Blessing authored
Constructors shouldn't throw exceptions. We also learned that different LDAP servers behave a bit unexpectedly sometimes - returning attributes we didn't ask for, or returned attributes with language subtypes.
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
Dylan Griffith authored
-
- Feb 12, 2018
-
-
Stan Hu authored
-
Michael Kozono authored
-
Michael Kozono authored
-
Rubén Dávila authored
This reverts commit a58f8c32, reversing changes made to cd5d75c3.
-
Alessio Caiazza authored
In the attempt to unify file uploading at workhorse level gitlab-org/gitlab-workhorse!230 we moved to a prefix-based tempfile creation in order to avoid upload collisions. Artifacts and LFS uploads already set original_filename to workhorse provided filename This commit add the same feature to `Gitlab::Middleware::Multipart`
-
-
- Feb 09, 2018
-
-
Ahmad Sherif authored
Fixes gitlab-development-kit#321
-
Robert Speicher authored
Restrict Todo API mark_as_done endpoint to the user's todos only
-
Douwe Maan authored
[10.4] Fix stored XSS in code blocks
-
Jarka Kadlecova authored
-
Robert Schilling authored
-
Robert Schilling authored
-
Robert Schilling authored
-