Skip to content
Snippets Groups Projects
  1. Feb 16, 2018
  2. Jan 11, 2018
  3. Jan 04, 2018
    • Sean McGivern's avatar
      Fix error when viewing diffs without blobs · 528b5eeb
      Sean McGivern authored
      Old merge requests can have diffs without corresponding blobs. (This also may be
      possible for commit diffs in corrupt repositories.)
      
      We can't use the `&.` operator on the blobs, because the blob objects are never
      nil, but `BatchLoader` instances that delegate to `Blob`. We can't use
      `Object#try`, because `Blob` doesn't inherit from `Object`.
      
      `BatchLoader` provides a `__sync` method that returns the delegated object, but
      using `itself` also works because it's forwarded, and will work for
      non-`BatchLoader` instances too. So the simplest solution is to just use that
      with the `&.` operator.
      528b5eeb
  4. Dec 22, 2017
  5. Dec 07, 2017
  6. Nov 21, 2017
  7. Nov 16, 2017
  8. Oct 30, 2017
  9. Oct 15, 2017
  10. Oct 13, 2017
  11. Oct 07, 2017
  12. Sep 25, 2017
  13. Sep 21, 2017
  14. Sep 19, 2017
  15. Sep 12, 2017
  16. Aug 24, 2017
    • Sean McGivern's avatar
      Show un-highlighted diffs when blobs are the same · e8525e10
      Sean McGivern authored
      For some old merge requests, we don't have enough information to figure out the
      old blob and the new blob for the file. This means that we can't highlight the
      diff correctly, but we can still display it without highlighting.
      e8525e10
  17. Aug 22, 2017
    • Sean McGivern's avatar
      Always return a simple diff viewer · b0f09406
      Sean McGivern authored
      We didn't have a fallback case before, because we believed the conditions were
      exhaustive. They weren't, so we can always fallback to not previewing.
      b0f09406
  18. Aug 14, 2017
  19. Aug 08, 2017
  20. Jul 31, 2017
  21. Jun 19, 2017
  22. Jun 14, 2017
  23. Jun 08, 2017
  24. Jun 06, 2017
  25. May 31, 2017
  26. May 29, 2017
  27. May 25, 2017
  28. May 24, 2017
  29. May 23, 2017
  30. May 18, 2017
  31. May 10, 2017
Loading