- Feb 16, 2018
-
-
ABaldwinHunter authored
It seems like this value is already nil
-
- Jan 11, 2018
-
-
- Jan 04, 2018
-
-
Sean McGivern authored
Old merge requests can have diffs without corresponding blobs. (This also may be possible for commit diffs in corrupt repositories.) We can't use the `&.` operator on the blobs, because the blob objects are never nil, but `BatchLoader` instances that delegate to `Blob`. We can't use `Object#try`, because `Blob` doesn't inherit from `Object`. `BatchLoader` provides a `__sync` method that returns the delegated object, but using `itself` also works because it's forwarded, and will work for non-`BatchLoader` instances too. So the simplest solution is to just use that with the `&.` operator.
-
- Dec 22, 2017
-
-
Douwe Maan authored
Improve performance of DiffDiscussion#truncated_diff_lines and DiffNote#diff_line by removing expensive diff position calculation and comparison
-
- Dec 07, 2017
-
-
Martin Nowak authored
- handle unchanged empty lines in inline diff
-
micael.bergeron authored
-
- Nov 21, 2017
-
-
Zeger-Jan van de Weg authored
After installing a new gem, batch-loader, a construct can be used to queue data to be fetched in bulk. The gem was also introduced in both gitlab-org/gitlab-ce!14680 and gitlab-org/gitlab-ce!14846, but those mrs are not merged yet. For the generation of diffs, both the old blob and the new blob need to be loaded. This for every file in the diff, too. Now we collect all these so we do 1 fetch. Three `.allow_n_plus_1_calls` have been removed, which I expect to be valid, but this needs to be confirmed by a full CI run. Possibly closes: - https://gitlab.com/gitlab-org/gitlab-ce/issues/37445 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37599 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37431
-
- Nov 16, 2017
-
-
Jacopo authored
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
-
- Oct 30, 2017
-
-
- Oct 15, 2017
-
-
Valery Sizov authored
-
- Oct 13, 2017
-
-
Alejandro Rodríguez authored
Having a distinct class just for that was a bit overkill
-
Alejandro Rodríguez authored
Rename classes to (hopefully) clearer names while we're doing that.
-
Alejandro Rodríguez authored
-
- Oct 07, 2017
-
-
- Sep 25, 2017
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- Sep 21, 2017
-
-
Ahmad Sherif authored
Closes gitaly#524
-
- Sep 19, 2017
-
-
Andrew Newdigate authored
-
- Sep 12, 2017
-
-
micael.bergeron authored
updated the spec
-
- Aug 24, 2017
-
-
Sean McGivern authored
For some old merge requests, we don't have enough information to figure out the old blob and the new blob for the file. This means that we can't highlight the diff correctly, but we can still display it without highlighting.
-
- Aug 22, 2017
-
-
Sean McGivern authored
We didn't have a fallback case before, because we believed the conditions were exhaustive. They weren't, so we can always fallback to not previewing.
-
- Aug 14, 2017
-
-
Robert Speicher authored
An upcoming update to rubocop-gitlab-security added additional violations.
-
- Aug 08, 2017
-
-
Brian Neel authored
-
- Jul 31, 2017
-
-
Jacob Vosmaer (GitLab) authored
-
- Jun 19, 2017
-
-
Douwe Maan authored
-
- Jun 14, 2017
-
-
Douwe Maan authored
-
- Jun 08, 2017
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- Jun 06, 2017
-
-
Douwe Maan authored
-
- May 31, 2017
-
-
Valery Sizov authored
-
- May 29, 2017
-
-
Douwe Maan authored
-
- May 25, 2017
-
-
Douwe Maan authored
-
- May 24, 2017
-
-
Douwe Maan authored
-
- May 23, 2017
-
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
- May 18, 2017
-
-
Douwe Maan authored
-
- May 10, 2017
-
-
Douwe Maan authored
-