- Apr 14, 2018
-
-
Stan Hu authored
-
- Mar 28, 2018
-
-
Jacob Vosmaer (GitLab) authored
-
- Mar 20, 2018
-
-
Pirate Praveen authored
-
- Mar 07, 2018
-
-
Stan Hu authored
We saw that in a customer instance, `empty?` was cached to be `true` even though `has_visible_content?` and `exists?` were `true`. This double caching can run into edge cases because there's no guarantee that the inner values will properly expire the outer one, especially if there is Redis replication lag. Consider this scenario: 1. `exists?` and `has_visible_content?` are false 2. `empty?` is expired 3. A subsequent call to `empty?` returns `true` because `exists?` is false even though `empty` is true 4. `exists?` and `has_visible_content?` are then expired 5. `exists?` and `has_visible_content?` are set to true 6. `empty?` is still stuck in the wrong value as `true` Closes #43882
-
Zeger-Jan van de Weg authored
-
Alejandro Rodríguez authored
-
- Mar 01, 2018
-
-
Tiago Botelho authored
-
- Feb 14, 2018
-
-
Stan Hu authored
-
Stan Hu authored
We removed the exception handling for Rugged errors in !16770, which revealed that the licensee gem attempts to retrieve a license file via Rugged in `refs/heads/master` by default. If that branch did not exist, a Rugged::ReferenceError would be thrown. There were two issues: 1. Not every project uses `master` as the default branch. This change uses the head commit to identify the license. 2. Removing the exception handling caused repositories to fail loading. We can safely catch and ignore any Rugged error because this means we weren't able to load a license file. Closes #43268
-
- Feb 07, 2018
-
-
Rubén Dávila authored
-
- Feb 02, 2018
-
-
Ahmad Sherif authored
Gitlab::Git::Repository#find_branch has a similar logic. Fixes #42609
-
- Feb 01, 2018
-
-
Zeger-Jan van de Weg authored
As part of gitlab-org/gitaly#884, this commit contains the client implementation for both TagNamesContaintingCommit and BranchNamesContainingCommit. The interface in the Repository model stays the same, but the implementation on the serverside, e.g. Gitaly, uses `for-each-ref`, as opposed to `branch` or `tag` which both aren't plumbing command. The result stays the same. On the serverside, we have the opportunity to limit the number of names to return. However, this is not supported on the front end yet. My proposal to use this ability: gitlab-org/gitlab-ce#42581. For now, this ability is not used as that would change more behaviours on a feature flag which might lead to unexpected changes on page refresh for example.
-
- Jan 30, 2018
-
-
Jacob Vosmaer (GitLab) authored
-
- Jan 29, 2018
-
-
- Jan 25, 2018
-
-
Jacob Vosmaer (GitLab) authored
-
- Jan 23, 2018
-
-
Ahmad Sherif authored
-
- Jan 16, 2018
-
-
Sean McGivern authored
A file containing /:\d+:/ in its contents would break the search results if those contents were part of the results, because we were splitting on colons, which can't work with untrusted input. Changing to use the null byte as a separator is much safer.
-
Andrew McCallum authored
-
- Jan 15, 2018
-
-
Andrew McCallum authored
-
Andrew McCallum authored
-
Andrew McCallum authored
-
- Jan 11, 2018
-
-
Ahmad Sherif authored
-
- Jan 10, 2018
-
-
Stan Hu authored
Closes #41739
-
- Jan 05, 2018
-
-
Alejandro Rodríguez authored
-
Lin Jen-Shin (godfat) authored
-
- Dec 20, 2017
-
-
Kim Carlbäcker authored
This reverts merge request !15712
-
- Dec 19, 2017
-
-
Zeger-Jan van de Weg authored
Uses `list_commits_by_oid` on the CommitService, to request the needed commits for pipelines. These commits are needed to display the user that created the commit and the commit title. This includes fixes for tests failing that depended on the commit being `nil`. However, now these are batch loaded, this doesn't happen anymore and the commits are an instance of BatchLoader.
-
- Dec 14, 2017
-
-
haseeb authored
-
- Dec 13, 2017
-
-
Jacopo authored
Allows ordering in GET api/v4/projects/:project_id/repository/contributors through `order_by` and `sort` params. The available `order_by` options are: name|email|commits. The available `sort` options are: asc|desc.
-
Ahmad Sherif authored
Closes gitaly#808
-
- Dec 12, 2017
-
-
Stan Hu authored
-
Kim "BKC" Carlbäcker authored
-
- Dec 08, 2017
-
-
Bob Van Landuyt authored
Moving the check out of the general requests, makes sure we don't have any slowdown in the regular requests. To keep the process performing this checks small, the check is still performed inside a unicorn. But that is called from a process running on the same server. Because the checks are now done outside normal request, we can have a simpler failure strategy: The check is now performed in the background every `circuitbreaker_check_interval`. Failures are logged in redis. The failures are reset when the check succeeds. Per check we will try `circuitbreaker_access_retries` times within `circuitbreaker_storage_timeout` seconds. When the number of failures exceeds `circuitbreaker_failure_count_threshold`, we will block access to the storage. After `failure_reset_time` of no checks, we will clear the stored failures. This could happen when the process that performs the checks is not running.
-
- Dec 07, 2017
-
-
Zeger-Jan van de Weg authored
-
- Dec 05, 2017
-
-
Ahmad Sherif authored
Closes gitaly#780
-
- Dec 04, 2017
-
-
Ahmad Sherif authored
Closes gitaly#737
-
- Nov 23, 2017
-
-
Lin Jen-Shin authored
-
- Nov 21, 2017
-
-
Jacob Vosmaer (GitLab) authored
-
- Nov 03, 2017
-
-
Alejandro Rodríguez authored
-
- Oct 27, 2017
-
-
Lin Jen-Shin (godfat) authored
-