- Oct 24, 2019
-
-
GitLab Release Tools Bot authored
Private/internal repository enumeration via bruteforce on a vulnerable URL See merge request gitlab/gitlabhq!3456
-
GitLab Release Tools Bot authored
Mask sentry auth token See merge request gitlab/gitlabhq!3464
-
GitLab Release Tools Bot authored
Sanitize search text to prevent XSS See merge request gitlab/gitlabhq!3470
-
GitLab Release Tools Bot authored
Require Maintainer permission on group where project is transferred to See merge request gitlab/gitlabhq!3473
-
GitLab Release Tools Bot authored
Use the '\A' and '\z' regex anchors in `InternalRedirect` to mitigate an Open Redirect issue. See merge request gitlab/gitlabhq!3476
-
GitLab Release Tools Bot authored
Pass all wiki markup formats through our Banzai pipeline filters See merge request gitlab/gitlabhq!3479
-
GitLab Release Tools Bot authored
Handle Stored XSS for Grafana URL in settings See merge request gitlab/gitlabhq!3481
-
David Wilkins authored
- Extend Gitlab::UrlBlocker to allow relative urls (require_absolute setting). The new `require_absolute` setting defaults to true, which is the existing behavior. - Extend AddressableUrlValidator to accept `require_abosolute` and default to the existing behavior - Add validation for ApplicationSetting#grafana_url to validate that the URL does not contain XSS but can be a valid relative or absolute url. - In the case of existing stored URLs, validate the stored URL does not contain XSS. If the stored URL contains stored XSS or is an otherwise invalid URL, return the default database column value. - Add tests for Gitlab::UrlBlocker to test require_absolute setting - Add tests for AddressableUrlValidator - Add tests for ApplicationSetting#grafana_url
-
GitLab Release Tools Bot authored
Filter out search results based on permissions to avoid bugs leaking data See merge request gitlab/gitlabhq!3494
-
- Oct 23, 2019
-
-
Dylan Griffith authored
This will be used later for search filtering.
-
Dylan Griffith authored
This is to be more consistent as there is already a :read_note policy in NotePolicy. To keep other behaviour the same we've introduced a Note#noteable_ability_name that is used anywhere this was expected.
-
- Oct 16, 2019
-
-
Luke Duncalfe authored
Previously, when the wiki page format was anything other than `markdown` or `asciidoc` the formatted content would be returned though a Gitaly call. Gitaly in turn would delegate formatting to the gitlab-gollum-lib gem, which in turn would delegate that to various gems (like RDoc for `rdoc`) and then apply some very liberal sanitization. It was too liberal! This change brings our wiki content formatting in line with how we format other markdown at GitLab, so we have a SSOT for sanitization. https://gitlab.com/gitlab-org/gitlab/issues/30540
-
Ryan Cobb authored
This makes it so we mask Sentry's auth token. This mask only occurs in the UI.
-
- Oct 14, 2019
-
-
Joern Schneeweisz authored
-
- Oct 11, 2019
-
-
Manoj M J authored
-
- Oct 10, 2019
-
-
Samantha Ming authored
-
- Oct 09, 2019
-
-
Kerri Miller authored
This method, #route_not_found, is executed as the final fallback for unrecognized routes (as the name might imply.) We want to avoid `#authenticate_user!` when calling `#route_not_found`; `#authenticate_user!` can, depending on the request format, return a 401 instead of redirecting to a login page. This opens a subtle security exploit where anonymous users will receive a 401 response when attempting to access a private repo, while a recognized user will receive a 404, exposing the existence of the private, hidden repo.
-
- Oct 07, 2019
-
-
GitLab Release Tools Bot authored
-
GitLab Release Tools Bot authored
[ci skip]
-
- Oct 02, 2019
-
-
GitLab Release Tools Bot authored
-
- Oct 01, 2019
-
-
GitLab Release Tools Bot authored
[ci skip]
-
Marin Jankovski authored
Fix private feature Elasticsearch leak See merge request gitlab/gitlabhq!3451
-
Mark Chao authored
Add spec to test different combinations. Accept string for required_minimum_access_level Allow more flexible project membership query
- Sep 30, 2019
-
-
Stan Hu authored
Fix broken specs : Generate new GPG key in place of expired one Closes #32956 See merge request gitlab-org/gitlab!17853
-
- Sep 26, 2019
-
-
GitLab Release Tools Bot authored
[ci skip]
-
GitLab Release Tools Bot authored
Fix Gitaly SearchBlobs flag RPC injection [Gitaly v1.59.3] See merge request gitlab/gitlabhq!3434
-
GitLab Release Tools Bot authored
Check that SAML identity linking validates the origin of the request See merge request gitlab/gitlabhq!3377
-
GitLab Release Tools Bot authored
Merge branch 'security-12717-fix-confidential-issue-assignee-visible-to-guests-12-2' into '12-2-stable' Display only participants that user has permission to see See merge request gitlab/gitlabhq!3402
-
GitLab Release Tools Bot authored
Prevent Bypassing Email Verification using Salesforce See merge request gitlab/gitlabhq!3406
-
GitLab Release Tools Bot authored
Only render fixed number of mermaid blocks See merge request gitlab/gitlabhq!3412
-
GitLab Release Tools Bot authored
Hide disabled project milestones in project settings on group level See merge request gitlab/gitlabhq!3415
-
GitLab Release Tools Bot authored
Redirect user to root path after unsubscribing from private resource See merge request gitlab/gitlabhq!3417
-
GitLab Release Tools Bot authored
Add policy check if cross reference system notes are accessible See merge request gitlab/gitlabhq!3427
-
GitLab Release Tools Bot authored
Cancel all running CI jobs when user is blocked See merge request gitlab/gitlabhq!3437
-
GitLab Release Tools Bot authored
Filter not accessible label events See merge request gitlab/gitlabhq!3441
- Sep 25, 2019
-
-
Alexandru Croitor authored
-