1. 28 Feb, 2020 1 commit
  2. 20 Dec, 2019 1 commit
  3. 11 Apr, 2019 1 commit
    • Thong Kuah's avatar
      Align UrlValidator to validate_url gem implementation. · d119d3d1
      Thong Kuah authored and James Lopez's avatar James Lopez committed
      Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement.
      Make use of the options attribute of the parent class ActiveModel::EachValidator.
      Add more options: allow_nil, allow_blank, message.
      Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
      d119d3d1
  4. 28 Mar, 2019 1 commit
  5. 17 Sep, 2018 1 commit
    • Yorick Peterse's avatar
      Added FromUnion to easily select from a UNION · 8a72f5c4
      Yorick Peterse authored
      This commit adds the module `FromUnion`, which provides the class method
      `from_union`. This simplifies the process of selecting data from the
      result of a UNION, and reduces the likelihood of making mistakes. As a
      result, instead of this:
      
          union = Gitlab::SQL::Union.new([foo, bar])
      
          Foo.from("(#{union.to_sql}) #{Foo.table_name}")
      
      We can now write this instead:
      
          Foo.from_union([foo, bar])
      
      This commit also includes some changes to make this new setup work
      properly. For example, a bug in Rails 4
      (https://github.com/rails/rails/issues/24193) would break the use of
      `from("sub-query-here").includes(:relation)` in certain cases. There was
      also a CI query which appeared to repeat a lot of conditions from an
      outer query on an inner query, which isn't necessary.
      
      Finally, we include a RuboCop cop to ensure developers use this new
      module, instead of using Gitlab::SQL::Union directly.
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
      8a72f5c4
  6. 26 Jul, 2018 1 commit
  7. 01 Jun, 2018 1 commit
  8. 05 Mar, 2018 1 commit