totalNotes is only used to prerender a number of
skeleton containers until real notes are loaded

issuable.discussions makes multiple requests, so
too expensive for this

This commit uses mere notes for this and sends
actual totalNotes number if it's less than 10;
otherwise it sends 10 - it allows us to avoid
bunch of skeleton prerenderings, which are not
necessary since they doesn't fit into the whole
screen and disappear quite fast

E'zeki&el Kigbo authored 5 years ago and Filipa Lacerda committed 5 years ago

i18n linting for .vue files under the
app/assets/javascripts/notes directory

- Moved discussion notes out of `NoteableDiscussion` component into a
new `DiscussionNotes` component
- Wrote Jest tests for the new `DiscussionNotes` component
- Updated Jest config for emojis fixtures
- Updated Karma tests `NoteableDiscussion` to match its new structure
- Convert `DiffDiscussions` tests to use Vue test utils

Adds discussion note style section under notes app from where
user can toggle discussion when they have selected a filter to show
only system notes.

Backports template and Vue changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9632 to CE

Move convertToDiscussion call from ReplyButton to NoteApp component

Sets `updated_at` so that the transformed note is returned together with
the new reply

This engine was replaced with CommonMarker in 11.4, it was deprecated
since then.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55141

Improve the renderign of new and existing discussions
by reducing the number of watchers on each object & array.
Previously every discussion change would trigger an update for every
discussion component.

Also tidied up some components to get them closer to our docs.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51506

This improves the initial rendering performance of notes
by only creating a new TaskList for the whole app,
rather than on a per-note component basis.

With multiple discussion requests we loose the reactivity of the
previously stored discussions state.
This means that certain features, toggling line discussions for example,
are no longer reactive.

The eslint-plugin-vue upgrade had some breaking changes to
vue/attribute-order which needed to be resolved in order to avoid
disabling the rule entirely

Partially addresses #47006.