- Feb 04, 2020
-
-
GitLab Bot authored
-
- Jan 29, 2020
-
-
GitLab Bot authored
-
- Jan 28, 2020
-
-
GitLab Bot authored
-
- Jan 15, 2020
-
-
GitLab Bot authored
-
- Dec 27, 2019
-
-
GitLab Bot authored
-
- Dec 19, 2019
-
-
GitLab Bot authored
-
- Dec 17, 2019
-
-
GitLab Bot authored
-
- Dec 04, 2019
-
-
GitLab Bot authored
-
- Dec 03, 2019
-
-
GitLab Bot authored
-
- Dec 01, 2019
-
-
GitLab Bot authored
-
- Nov 28, 2019
-
-
GitLab Bot authored
-
- Nov 25, 2019
-
-
GitLab Bot authored
-
- Nov 07, 2019
-
-
GitLab Bot authored
-
- Oct 16, 2019
-
-
GitLab Bot authored
-
- Oct 03, 2019
-
-
GitLab Bot authored
-
- Sep 19, 2019
-
-
GitLab Bot authored
-
- Sep 18, 2019
-
-
GitLab Bot authored
-
- Sep 13, 2019
-
-
GitLab Bot authored
-
GitLab Bot authored
-
- Sep 12, 2019
-
-
Peter Leitzen authored
`(const nil :Foo)` vs `(const nil? :Foo)`
-
- Sep 10, 2019
-
-
Alessio Caiazza authored
This cop prevents you from using file in API, it points you to the development documentation about workhorse file acceleration.
-
- Aug 28, 2019
-
-
Yorick Peterse authored
This ensures the InjectEnterpriseEditionModule cop is able to detect the prepend patterns used in the qa/ directory. Previously it would not detect them as all EE QA modules reside in QA::EE, and not the top-level EE namespace.
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
Use Rubocop's Include instead of manually checking the matcher in controllers specs.
-
Vitali Tatarintev authored
BeSuccessMatcher now supports following examples: ``` expect(response).to be_success expect(response).to_not be_success expect(response).not_to be_success is_expected.to be_success is_expected.to_not be_success is_expected.not_to be_success ```
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
-
Vitali Tatarintev authored
Prevent using `be_success` call in controller specs to avoid getting following deprecation warning: ``` DEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0. Please use successful? as provided by Rack::Response::Helpers. ```
-
- Aug 26, 2019
-
-
Peter Leitzen authored
Stop checking the file location programmatically.
-
- Aug 23, 2019
-
-
Mayra Cabrera authored
This cop will analyze migrations that add columns with string, and report an offense if the string has no limit enforced Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64505
-
- Aug 01, 2019
-
-
Sean McGivern authored
The RSpec/FilePath cop checks that a spec file's path is correct, but only if the file describes a constant. We want to check, for any file with a top-level `describe`, whether the file path ends in `_spec.rb`. We don't care what comes before that; just that it will be executed by RSpec at all.
-
- Jul 30, 2019
-
-
Yorick Peterse authored
This extends the InjectEnterpriseEditionModule RuboCop cop so that it verifies the following: 1. The line number the injection occurs on (as before). 2. The method used (e.g. prepend instead of prepend_if_ee). 3. The argument type passed when using the new module injection methods.
-
- Jul 10, 2019
-
-
Daniel Davison authored
Using quotes within string validations can be messy. Let's use a typical CSS selector for an unquoted attribute Update the cop spec to validate appropriate new message
-
Daniel Davison authored
In order to break away from using CSS classes as our primary method of element identification, we need to provide the ability to search for data attributes. Make Test::Sanity::Selectors now work Utilize regex to match on literal strings of the element name Suggest the data-qa-selector pattern vs the qa- Add data-qa-selector to login page to start We need a page that is heavily used in order to be confident that this functionality works. Let's start with the Login page Use appropriate HAML data tag practices
-
Mayra Cabrera authored
Suggests to use a JSON structured log instead Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
-
- Jun 21, 2019
-
-
Bob Van Landuyt authored
-
- May 21, 2019
-
-
Luke Duncalfe authored
This provides the user with some context as to why certain ActiveRecord methods are blacklisted.
-
- May 20, 2019
-
-
Daniel Davison authored
Elements now have the ability to be required on pages or not Currently using the default wait mechanism Altered the ElementWithPattern Cop to fit new splat for init
-