- Jun 06, 2018
-
-
- Jun 05, 2018
-
-
Bob Van Landuyt authored
By specifying a presenter for the object type, we can keep the logic out of `GitlabSchema`. The presenter gets initialized using the object being presented, and the context (including the `current_user`).
-
- May 09, 2018
-
-
- May 08, 2018
-
-
James Lopez authored
-
- Apr 30, 2018
-
-
Oswaldo Ferreir authored
-
- Apr 26, 2018
-
-
Victor Wu authored
-
- Feb 01, 2018
-
-
Yorick Peterse authored
This ensures that we have more visibility in the number of SQL queries that are executed in web requests. The current threshold is hardcoded to 100 as we will rarely (maybe once or twice) change it. In production and development we use Sentry if enabled, in the test environment we raise an error. This feature is also only enabled in production/staging when running on GitLab.com as it's not very useful to other users.
-
- Jan 02, 2018
-
-
Lin Jen-Shin authored
-
- Dec 15, 2017
-
-
- Dec 06, 2017
-
-
Rémy Coutable authored
Add "Guidelines for implementing Enterprise Edition features" in CE development doc since the doc page is already there Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- Dec 05, 2017
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- Nov 21, 2017
-
-
Lin Jen-Shin authored
-
- Nov 16, 2017
-
-
Eric Eastwood authored
-
- Nov 15, 2017
-
-
Eric Eastwood authored
-
- Nov 07, 2017
-
-
Yorick Peterse authored
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.
-
- Nov 01, 2017
-
-
- Oct 11, 2017
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
-
- Oct 09, 2017
-
-
Achilleas Pipinellis authored
-
- Oct 05, 2017
-
-
James Ramsay authored
-
- Sep 27, 2017
-
-
- Sep 12, 2017
-
-
Robert Speicher authored
-
- Sep 11, 2017
-
-
Yorick Peterse authored
-
- Aug 16, 2017
-
-
Yorick Peterse authored
-
Yorick Peterse authored
-
Yorick Peterse authored
-
- Jul 07, 2017
-
-
Yorick Peterse authored
This module provides a class method called `each_batch` that can be used to iterate tables in batches in a more efficient way compared to Rails' `in_batches` method. This commit also includes a RuboCop cop to blacklist the use of `in_batches` in favour of this new method.
-
Yorick Peterse authored
This module provides a class method called `each_batch` that can be used to iterate tables in batches in a more efficient way compared to Rails' `in_batches` method. This commit also includes a RuboCop cop to blacklist the use of `in_batches` in favour of this new method.
-
- Jun 29, 2017
-
-
Yorick Peterse authored
These attributes are stored in binary in the database, but exposed as strings. This allows one to query/create data using plain SHA1 hashes as Strings, while storing them more efficiently as binary.
-
- Jun 12, 2017
-
-
Yorick Peterse authored
Background migrations can be used to perform long running data migrations without these blocking a deployment procedure. See MR https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11854 for more information.
-
- Jun 07, 2017
-
-
Yorick Peterse authored
-
Yorick Peterse authored
Instead of using polymorphic associations a developer should use separate tables.
-
- May 31, 2017
-
-
Alejandro Rodríguez authored
-
Yorick Peterse authored
-
- May 16, 2017
-
-
Rubén Dávila authored
-
- May 08, 2017
-
-
Yorick Peterse authored
[ci skip]
-
- May 05, 2017
-
-
- Apr 25, 2017
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- Mar 29, 2017
-
-
Achilleas Pipinellis authored
-
- Mar 22, 2017
-
-
Filipa Lacerda authored
-