We had similar code in a few places to redirect to the last page if
the given page number is out of range. This unifies the handling in a
new controller concern and adds usage of it in all snippet listings.

Peter Leitzen authored Jul 16, 2019 and Grzegorz Bizon committed Jul 16, 2019

Prefer `json_response` where applicable.

It persist temporary personal snippets under
user/:id namespaces temporarily while creating
a upload record to track it. If an user gets removed
while it's still a tmp upload, it also gets removed.
If the tmp upload is sent, the upload gets moved to
personal_snippets/:id as before. The upload record
also gets updated to the new model type as well.

Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758

Previously one could move any temp/ sub folder around.

Removing workhorse_set_content_type feature flag introduced in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22667

Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`

Use uploads/system directory for personal snippets

See merge request !2123

Douwe Maan authored Apr 28, 2017 and Bob Van Landuyt :neckbeard: committed May 10, 2017

Refactor snippets finder & dont return internal snippets for external users

See merge request !2094

Sean McGivern authored Apr 25, 2017 and Bob Van Landuyt :neckbeard: committed May 10, 2017

Fix snippets visibility for show action - external users can not see internal snippets

See merge request !2087

This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.

Apply the same spam checks to public snippets (either personal snippets
that are public, or public snippets on public projects) as to issues on
public projects.

Signed-off-by: Rémy Coutable <remy@rymai.me>

ref: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6720

Also incorporate feedback