Skip to content
Snippets Groups Projects
  1. Apr 17, 2018
  2. Apr 09, 2018
  3. Apr 03, 2018
  4. Mar 07, 2018
  5. Feb 01, 2018
  6. Jan 30, 2018
  7. Dec 22, 2017
  8. Oct 11, 2017
  9. Sep 07, 2017
  10. Aug 10, 2017
    • Yorick Peterse's avatar
      Migrate events into a new format · 0395c471
      Yorick Peterse authored
      This commit migrates events data in such a way that push events are
      stored much more efficiently. This is done by creating a shadow table
      called "events_for_migration", and a table called "push_event_payloads"
      which is used for storing push data of push events. The background
      migration in this commit will copy events from the "events" table into
      the "events_for_migration" table, push events in will also have a row
      created in "push_event_payloads".
      
      This approach allows us to reclaim space in the next release by simply
      swapping the "events" and "events_for_migration" tables, then dropping
      the old events (now "events_for_migration") table.
      
      The new table structure is also optimised for storage space, and does
      not include the unused "title" column nor the "data" column (since this
      data is moved to "push_event_payloads").
      
      == Newly Created Events
      
      Newly created events are inserted into both "events" and
      "events_for_migration", both using the exact same primary key value. The
      table "push_event_payloads" in turn has a foreign key to the _shadow_
      table. This removes the need for recreating and validating the foreign
      key after swapping the tables. Since the shadow table also has a foreign
      key to "projects.id" we also don't have to worry about orphaned rows.
      
      This approach however does require some additional storage as we're
      duplicating a portion of the events data for at least 1 release. The
      exact amount is hard to estimate, but for GitLab.com this is expected to
      be between 10 and 20 GB at most. The background migration in this commit
      deliberately does _not_ update the "events" table as doing so would put
      a lot of pressure on PostgreSQL's auto vacuuming system.
      
      == Supporting Both Old And New Events
      
      Application code has also been adjusted to support push events using
      both the old and new data formats. This is done by creating a PushEvent
      class which extends the regular Event class. Using Rails' Single Table
      Inheritance system we can ensure the right class is used for the right
      data, which in this case is based on the value of `events.action`. To
      support displaying old and new data at the same time the PushEvent class
      re-defines a few methods of the Event class, falling back to their
      original implementations for push events in the old format.
      
      Once all existing events have been migrated the various push event
      related methods can be removed from the Event model, and the calls to
      `super` can be removed from the methods in the PushEvent model.
      
      The UI and event atom feed have also been slightly changed to better
      handle this new setup, fortunately only a few changes were necessary to
      make this work.
      
      == API Changes
      
      The API only displays push data of events in the new format. Supporting
      both formats in the API is a bit more difficult compared to the UI.
      Since the old push data was not really well documented (apart from one
      example that used an incorrect "action" nmae) I decided that supporting
      both was not worth the effort, especially since events will be migrated
      in a few days _and_ new events are created in the correct format.
      Verified
      0395c471
  11. Aug 02, 2017
  12. Jul 28, 2017
  13. Jul 17, 2017
  14. Jul 05, 2017
  15. May 17, 2017
  16. Apr 07, 2017
  17. Apr 05, 2017
  18. Apr 03, 2017
  19. Mar 04, 2017
  20. Jan 31, 2017
  21. Jan 17, 2017
  22. Dec 10, 2016
  23. Dec 04, 2016
  24. Oct 14, 2016
    • Stan Hu's avatar
      Fix trending projects Spinach failure · 5b5c7e04
      Stan Hu authored
      The trending projects list is now pre-calculated. To make this work
      with the Spinach test, we have to manually refresh the list.
      
      Partial fix to #23378
      5b5c7e04
  25. Sep 01, 2016
  26. Jul 05, 2016
  27. Jun 03, 2016
  28. May 20, 2016
  29. Apr 21, 2016
  30. Apr 18, 2016
  31. Apr 12, 2016
  32. Apr 11, 2016
  33. Feb 04, 2016
  34. Jan 15, 2016
Loading