Skip to content
Snippets Groups Projects
  1. Mar 17, 2020
  2. Aug 20, 2019
    • Luke Duncalfe's avatar
      Add service classes for mutating AwardEmoji · 37b17fa6
      Luke Duncalfe authored
      Adding, destroying and toggling emoji previously lacked services and
      instead were performed through methods called on Awardable models.
      
      This led to inconsistencies where relevant todos would be marked as done
      only when emoji were awarded through our controllers, but not through
      the API. Todos could also be marked as done when an emoji was being
      removed.
      
      Behaviour changes
      
      - Awarding emoji through the API will now mark a relevant Todo as done
      - Toggling an emoji off (destroying it) through our controllers will no
        longer mark a relevant Todo as done
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
      37b17fa6
Loading