Skip to content
Snippets Groups Projects
  1. Mar 17, 2020
  2. Jan 22, 2020
  3. Jan 17, 2020
  4. Dec 16, 2019
  5. Sep 13, 2019
  6. Aug 27, 2019
  7. Aug 26, 2019
  8. Jun 19, 2019
  9. Apr 05, 2019
  10. Nov 15, 2018
  11. Nov 13, 2018
  12. Oct 01, 2018
  13. Sep 26, 2018
  14. Aug 30, 2018
  15. Jul 24, 2018
  16. Jul 18, 2018
  17. Feb 02, 2018
  18. Nov 23, 2017
  19. Aug 31, 2017
    • Sean McGivern's avatar
      `current_application_settings` belongs on `Gitlab::CurrentSettings` · 5883ce95
      Sean McGivern authored
      The initializers including this were doing so at the top level, so every object
      loaded after them had a `current_application_settings` method. However, if
      someone had rack-attack enabled (which was loaded before these initializers), it
      would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
      have that method.
      
      To fix this:
      
      1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
         `Object.new.current_application_settings` to work.
      2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
         like that in several places.
      3. Change the initializers to use that new form.
      5883ce95
  20. Jun 23, 2017
  21. Apr 26, 2017
  22. Apr 25, 2017
  23. Apr 13, 2017
  24. Apr 09, 2017
  25. Apr 04, 2017
  26. Mar 30, 2017
  27. Mar 27, 2017
Loading