Skip to content
Snippets Groups Projects
  1. Feb 21, 2020
  2. Feb 10, 2020
  3. Feb 04, 2020
  4. Jan 22, 2020
  5. Nov 27, 2019
  6. Oct 30, 2019
  7. Oct 18, 2019
  8. Oct 11, 2019
  9. Nov 19, 2018
  10. Feb 13, 2018
  11. Dec 12, 2017
  12. Dec 05, 2017
  13. Jul 21, 2017
  14. Oct 21, 2016
    • Yorick Peterse's avatar
      Re-organize queues to use for Sidekiq · 97731760
      Yorick Peterse authored
      Dumping too many jobs in the same queue (e.g. the "default" queue) is a
      dangerous setup. Jobs that take a long time to process can effectively
      block any other work from being performed given there are enough of
      these jobs.
      
      Furthermore it becomes harder to monitor the jobs as a single queue
      could contain jobs for different workers. In such a setup the only
      reliable way of getting counts per job is to iterate over all jobs in a
      queue, which is a rather time consuming process.
      
      By using separate queues for various workers we have better control over
      throughput, we can add weight to queues, and we can monitor queues
      better. Some workers still use the same queue whenever their work is
      related. For example, the various CI pipeline workers use the same
      "pipeline" queue.
      
      This commit includes a Rails migration that moves Sidekiq jobs from the
      old queues to the new ones. This migration also takes care of doing the
      inverse if ever needed. This does require downtime as otherwise new jobs
      could be scheduled in the old queues after this migration completes.
      
      This commit also includes an RSpec test that blacklists the use of the
      "default" queue and ensures cron workers use the "cronjob" queue.
      
      Fixes gitlab-org/gitlab-ce#23370
      Unverified
      97731760
Loading