Fix error rendering submodules in MR diffs when there is no .gitmodules

See merge request gitlab-org/gitlab-ce!31162

(cherry picked from commit 55f99e93)

cfef1e8e Fix error rendering submodules in MR diffs when there is no .gitmodules

Ensure SubmoduleHelper works outside view context

Closes #64833

See merge request gitlab-org/gitlab-ce!31005

(cherry picked from commit 8b284a51)

26ac53b3 Ensure SubmoduleHelper works outside view context

Re-enables and autocorrects all instances of the
Style/MethodCallWithoutArgsParentheses rule

Before this change only last namespace in full path was extracted. It's
fine unless you have a link to submodule under subgroups. In that case
self_url? method returns false and link is processed as external. I
could not find a proper regex to cover all cases and correctly extract
full path to repository and instead used current instance host name
to get correct path to namespace and project.

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Users attempting to access repositories that had `.gitmodules` entries
with trailing whitespaces would encounter an Error 500. This was due
to a change in bf876ec7 that quietly removed the whitespace stripping.

Closes #33018

Sometimes it is useful to store submodules in the same repository which
contains links to them.  Make the UI support this.

See
https://github.com/twosigma/git-meta/wiki/The-Omega-Repo


for information about this strategy

Signed-off-by: David Turner <novalis@novalis.org>

Douwe Maan authored 7 years ago and Bob Van Landuyt :neckbeard: committed 7 years ago

Sanitize submodule URLs before linking to them in the file tree view

See merge request !2084

Signed-off-by: David Turner <novalis@novalis.org>

Fix Error 500 when relative submodule resolves to a namespace that has a different name from its path

Closes #1849

Closes https://github.com/gitlabhq/gitlabhq/issues/7554

Closes #775

Make the following changes to deal with new behavior in Rails 4.1.2:

* Use nested resources to avoid slashes in arguments to path helpers.

Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Detect if submodule is hosted on this GitLab server, gitlab.com or github.com.
Hash links directly to commit in repo.