Sam Bigelow authored 5 years ago and Paul Slaughter committed 5 years ago

Add keyboard shortcuts `p` and `n` to navigate duscussions.

- expand upwards
- expand downwards
- expand all

in both inline and parallel views

- all commits squashed to make danger review happy

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56523

Correctly updates the URL without overwriting parameters
Reloads the diff file content without reloading the page

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58852, https://gitlab.com/gitlab-org/gitlab-ce/issues/42597

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58597

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53139

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51737

Phil Hughes authored 6 years ago and Mark Chao committed 6 years ago

The user can also toggle between the diff changes and
the full file diff.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/19054

Mousetrap is used as the help-tool to listen to keystrokes

Added currentDiffIndex getter to store that holds
the index of currently active diff file in the list

Instead of computing it on the component, we will take advantage of it
being available for all components in DiffsApp

Testing keyboard navigation and jumpToFile()

Fixes some diff files not rendering when the renderIt
property is updated.
Previously it was using a local copy of renderIt which meant
Vue wouldn't update it when the files renderIt property was updates

- replaced file.too_large
- replaced file.text
- replaced file.collapsed

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51857

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56797

Put the statistics in the compare-versions header for the entire MR
Put them in the file header for each individual file

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53304

Dropdown includes buttons for tree view rendering mode
and buttons for the compare view (inline or side-by-side)

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55491

Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and
diff discussion `truncated_diff_lines` were inconsistent: `text` and
`rich_text` on the latter included the leading +/-/<space> character,
like on the backend, while the former had no `text` and its `rich_text`
had dropped this char.

This resulted in a bug when the suggestions feature expected these diff
line objects to be identical in format and thus interchangeable, which
was not the case.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53069

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54807

The diff notes automatically focus on mount, and when using the index
(as opposed to line_code) for the v-bind:key, the comment form gets
unnecessarily remounted, and therefore refocused.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55388

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55248, https://gitlab.com/gitlab-org/gitlab-ce/issues/55245