Skip to content
Snippets Groups Projects
  1. Feb 20, 2020
  2. Feb 13, 2020
  3. Jan 14, 2020
  4. Aug 10, 2019
  5. Mar 06, 2019
  6. Feb 15, 2019
  7. Feb 13, 2019
  8. Jan 24, 2019
  9. Jan 22, 2019
    • Douwe Maan's avatar
      Trim first char of diff line text on diff discussions · 03df54b2
      Douwe Maan authored
      Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and
      diff discussion `truncated_diff_lines` were inconsistent: `text` and
      `rich_text` on the latter included the leading +/-/<space> character,
      like on the backend, while the former had no `text` and its `rich_text`
      had dropped this char.
      
      This resulted in a bug when the suggestions feature expected these diff
      line objects to be identical in format and thus interchangeable, which
      was not the case.
      Unverified
      03df54b2
  10. Jan 16, 2019
  11. Jan 08, 2019
  12. Dec 18, 2018
    • Sam Bigelow's avatar
      Utilize :key to minimize extra rerenders · 9c187982
      Sam Bigelow authored
      The diff notes automatically focus on mount, and when using the index
      (as opposed to line_code) for the v-bind:key, the comment form gets
      unnecessarily remounted, and therefore refocused.
      9c187982
  13. Dec 06, 2018
  14. Dec 05, 2018
  15. Nov 14, 2018
    • Phil Hughes's avatar
      Made diff & note data consistent · 234563ba
      Phil Hughes authored
      This caused many pain points when working with it.
      Part of the data was camel cased the other snake case.
      Other parts where snake case & then getting converted in components,
      this conversion has the potential for leaking memory.
      
      This changes that & makes it consistent with what it returned from the
      API, snake case.
      Unverified
      234563ba
  16. Oct 23, 2018
  17. Oct 17, 2018
  18. Oct 03, 2018
    • Phil Hughes's avatar
      Added file tree to merge request diffs · 33c4c5b8
      Phil Hughes authored
      This file tree displays all the diff files in a tree like format
      Each file is taken and converted into a tree with folders
      Each folder can be toggled open & closed
      Clicking a file will scroll to the diff file & highlight with a glow affect
      
      Searching the tree list will search only files & return a list of the
      files without any folders
      
      Each file row contains an icon to show changed, new file or deleted
      Each row will also contain the added & removed lines count
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
      Unverified
      33c4c5b8
  19. Oct 01, 2018
    • Mark Chao's avatar
      Fix MR discussion not loaded issue · f09303b0
      Mark Chao authored
      Display `formatter` as the sole content of `position` object.
      This means `diff_file` data is not referenced, which is the
      caseu of "IOError: not opened for reading".
      f09303b0
  20. Sep 21, 2018
  21. Sep 18, 2018
  22. Sep 17, 2018
  23. Sep 10, 2018
  24. Sep 08, 2018
  25. Sep 07, 2018
  26. Aug 01, 2018
  27. Jul 17, 2018
  28. Jul 05, 2018
  29. Jun 21, 2018
Loading