Skip to content
Snippets Groups Projects
  1. Feb 25, 2020
  2. Feb 18, 2020
  3. Feb 06, 2020
  4. Jan 27, 2020
  5. Jan 23, 2020
  6. Jan 16, 2020
  7. Jan 14, 2020
  8. Jan 13, 2020
  9. Dec 18, 2019
  10. Dec 17, 2019
  11. Nov 14, 2019
  12. Nov 02, 2019
  13. Oct 22, 2019
    • Luke Duncalfe's avatar
      Pass all wiki markup formats through pipelines · 49a78d41
      Luke Duncalfe authored
      Previously, when the wiki page format was anything other than `markdown`
      or `asciidoc` the formatted content would be returned though a Gitaly
      call. Gitaly in turn would delegate formatting to the gitlab-gollum-lib
      gem, which in turn would delegate that to various gems (like RDoc for
      `rdoc`) and then apply some very liberal sanitization.
      
      It was too liberal!
      
      This change brings our wiki content formatting in line with how we
      format other markdown at GitLab, so we have a SSOT for sanitization.
      
      https://gitlab.com/gitlab-org/gitlab/issues/30540
      49a78d41
  14. Sep 30, 2019
  15. Sep 02, 2019
  16. Aug 21, 2019
    • Oswaldo Ferreir's avatar
      Avoid exposing unaccessible repo data upon GFM processing · 4daf3dc0
      Oswaldo Ferreir authored
      When post-processing relative links to absolute links
      RelativeLinkFilter didn't take into consideration that
      internal repository data could be exposed for users
      that do not have repository access to the project.
      
      This commit solves that by checking whether the user
      can `download_code` at this repository, avoiding any
      processing of this filter if the user can't.
      
      Additionally, if we're processing for a group (
      no project was given), we check if the user can
      read it in order to expand the href as an extra.
      That doesn't seem necessarily a breach now,
      but an extra check doesn't hurt as after all
      the user needs to be able to `read_group`.
      4daf3dc0
  17. Jul 07, 2019
  18. Jun 29, 2019
    • Stan Hu's avatar
      Fix attachments using the wrong URLs in e-mails · 0e341a6e
      Stan Hu authored
      Prior to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29889,
      only the project context were set for the Markdown renderer. For a note
      on an issuable, the group context was set to `nil` because
      `note.noteable.try(:group)` attempted to get the issuable's group, which
      doesn't exist.
      
      To make group notifications work, now both the project and group context
      are set. The context gets passed to `RelativeLinkFilter`, which
      previously assumed that it wasn't possible to have both a group and a
      project in the Markdown context. However, if a group were defined, it
      would take precedence, and the URL rendered for uploads would be
      `/group/-/uploads` instead of `/group/project/uploads/`. This led to
      404s in e-mails.
      
      However, now that we have both project and group in the context, we
      render the Markdown giving priority to the project context if is set.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63910
      0e341a6e
  19. Jun 05, 2019
    • Patrick Bajao's avatar
      Use Redis for CacheMarkDownField on non AR models · 2eecfd8f
      Patrick Bajao authored
      This allows using `CacheMarkdownField` for models that are not backed
      by ActiveRecord.
      
      When the including class inherits `ActiveRecord::Base` we include
      `Gitlab::MarkdownCache::ActiveRecord::Extension`. This will cause the
      markdown fields to be rendered and the generated HTML stored in a
      `<field>_html` attribute on the record. We also store the version
      used for generating the markdown.
      
      All other classes that include this model will include the
      `Gitlab::MarkdownCache::Redis::Extension`. This add the `<field>_html`
      attributes to that model and will generate the html in them. The
      generated HTML will be cached in redis under the key
      `markdown_cache:<class>:<id>`. The class this included in must
      therefore respond to `id`.
      2eecfd8f
  20. Feb 04, 2019
  21. Sep 13, 2018
    • Brett Walker's avatar
      Remove images in 'first_line_in_markdown' · 635d9012
      Brett Walker authored
      By default, we now strip images in the 'first_line_in_markdown'
      method.  This keeps images from being displayed in the
      one-liner of both todo and project activity panels.
      
      Although not currently used, we allow images to be preserved
      with the allow_images: true options.
      635d9012
  22. Sep 05, 2018
  23. Jul 11, 2018
  24. Jul 06, 2018
  25. Jun 14, 2018
  26. Dec 22, 2017
  27. Dec 04, 2017
  28. Nov 06, 2017
  29. Sep 06, 2017
  30. Aug 02, 2017
  31. Aug 01, 2017
  32. Jul 05, 2017
  33. Jun 21, 2017
  34. Apr 27, 2017
Loading