Patrick Bajao authored 5 years ago and Justin Boyson committed 5 years ago

Move it to DiffPositionableNote concern which will be re-used
in EE in DraftNote model.

Most/all of the work we're doing in this method is done at creation/edit
time, so do we need to also check at render? Assume if you've gotten to
this point, it's ok to enable the suggestion filter.

Getting the `repository` directly from the noteable in DiffNotes
allows us to use a different repository when the DiffNote is not
on a project repository.

It is only the first step in decoupling the DiffNote from a project's
main repository.

This turns Notable::RESOLVABLE_TYPES into a
`Notable.resolvable_types`. That allows us to override it in EE.

Adds the groundwork needed in order to persist multi-line suggestions,
while providing the parsing strategy which will be reused for the
**Preview** as well.

Implements the filtering logic for
`suggestion:-x+y` syntax.

This is an issue that can only be seen through EE. Further
details can be seen on
https://gitlab.com/gitlab-org/gitlab-ee/issues/9876. In general
we should always use the latest diff version of a file in order
to both create and apply suggestions.

This reverts commit a82a5957, reversing
changes made to e7df959b.

Partially addresses #47424.

We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response.
With this change we solve this problem and simplify a lot fetching this piece of info.

Today, when fetching diffs of a note, we always go to Gitaly in order to diff between commits and return the diff of each discussion note. With this change we avoid doing that for notes on the "current version" of the MR.

Improve performance of DiffDiscussion#truncated_diff_lines and DiffNote#diff_line by removing expensive diff position calculation and comparison

This cop has been renamed to ActiveRecordSerialize to match the way
"ActiveRecord" is usually written.

This Cop blacklists the use of ActiveRecord's "serialize" method, except
for cases where we already use this.