This fixes https://gitlab.com/gitlab-org/gitlab/issues/37766 which is
caused by the fact that we leave the stale permissions data in the index
after a group is moved to another group.

When a restricted visibility level of `private` is set in the instance,
creating a snippet with the `visibility` level would always fail.
This happened because:

1. `params[:visibility]` was a string (e.g. "public")
2. `CreateSnippetService` and `UpdateSnippetService` only looked
   at `params[:visibility_level]`, which was `nil`.

To fix this, we:

1. Make `CreateSnippetService` look at the newly-built
   `snippet.visibility_level`, since the right value is assigned by the
   `VisibilityLevel#visibility=` method.
2. Modify `UpdateSnippetService` to handle both `visibility_level` and
`visibility` parameters.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66050

- Adds UI to configure in group and project settings
- Removes notification configuration for users when
disabled at group or project level

These are not required because MySQL is not
supported anymore

Updates changed method names and fixes spec failures

Suggests to use a JSON structured log instead

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102

- Externalize strings in milestones_helper
- Externalize strings in app/services
- Update PO file

The `#reload` makes to load all objects into memory,
and the main purpose of `#reload` is to drop the association cache.

The `#reset` seems to solve exactly that case.

Added changelog and rebased

MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9815

- Includes instance methods on Group model to detect when a group has
AutoDevOps explicitly/implicitly enabled/disabled.
- Includes migration to add a new column to namespaces table
- Add UI necessary modifications
- Add service and controller to update auto devops
related instances
- Updates project and groups auto devops badges

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52447

This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points

Fix misspellings in app/spec comments

See merge request gitlab-org/gitlab-ce!25517

This reverts commit 9202bbd1, reversing
changes made to 4b282e9c.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

- we now use the hierarchy class also for epics
- also rename supports_nested_groups? into supports_nested_objects?
  - move it to a concern

These can just be `delete` calls, with the caveat that it only takes one
argument.

Fix leaking information of confidential issues on TODOs
when user is downgraded to guest access.

This was causing problems in EE, where audit events were being
generated even if the project failed to save.

This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.

For directories application_settings --> labels.

Partially addresses #47424.

It allows user to automatically import multiple repositories
with nested structure by uploading a manifest xml file.

AOSP project was used as an example during development of this feature.

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

James Lopez authored 7 years ago and Robert Speicher committed 7 years ago

[10.4] Fix GH namespace security issue

This removes all usage of soft removals except for the "pending delete"
system implemented for projects. This in turn simplifies all the query
plans of the models that used soft removals. Since we don't really use
soft removals for anything useful there's no point in keeping it around.

This _does_ mean that hard removals of issues (which only admins can do
if I'm not mistaken) can influence the "iid" values, but that code is
broken to begin with. More on this (and how to fix it) can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/31114.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447

…in Groups::UpdateService instead of only in the browser.

Since we don't support nested groups on MySQL, raise an error
explaining that on import instead of trying anyway.