The current state of group issue boards does not show the "Add issues"
button on the UI for users that are reporters of group child projects.

- Adds CSS classes to represent browser & platform
- Adds JS flags to `gl` object to represent
browser & platform

Filipa Lacerda authored 5 years ago and Mayra Cabrera committed 5 years ago

Updates frontend code and specs to allow for the new
feature flag

This commit adds a warning message that is always displayed that informs
users that their GitLab Pages sites will take a bit of time before they
can be accessed after being deployed for the first time.

When deployable is nil, we gracefully take care of the case.

- Use "results" instead of "blobs", "wiki blobs", "snippet blobs"
- Use "comments" instead of "notes"
- Use correct pluralization
- Don't add "1 - 10 of" if there's only one page

rails_helper.rb's only logic was to require
spec_helper.rb.

Payton Burdette authored 5 years ago and Filipa Lacerda committed 5 years ago

Add changelog entry

Remove unnecessary test checking for form value

Translations updated for gitlab.pot

Use proper format on changelog entry

These services aren't specific to GCP, and will be used for AWS
as part of https://gitlab.com/gitlab-org/gitlab-ce/issues/46686

Only displays the todo body if the todo has a note.
This is to avoid redundant Issue or Merge Request titles
displayed both in the Todo title and body.

allow_bypass_two_factor configration dose not work with saml provider

Scott Hampton authored 5 years ago and Mayra Cabrera committed 5 years ago

Some pipeline status icon tooltips were showing
"Commit: ..." which customers found to be
misleading since it was not the commit that was
failing but the pipeline.

We are changing all status icon tooltips to say
"Pipeline: ..." instead of "Commit: ..." now.

Projects that have a pipeline may need to check whether the user has
permission to read the build (`can?(current_user, :read_build,
project)`), which requires checking the `project_features` table.
This would cause an N+1 SQL query for each project.

This change also has a beneficial side effect that may avoid a race
condition. When a user deletes a project, the project is queued for
deletion and the user is redirected back to the dashboard page. However,
the following may happen:

1. The dashboard page may load this deleted project in the list of
20 projects.
2. The view will load the project pipeline status from the cache and
attempt to show each project.
3. When the view encounters the deleted project, it calls
`can?(current_user, :read_build, project)` to determine whether to
display the pipeline status.
4. Sidekiq deletes the project from the database.
5. However, since the deleted project is still loaded in memory, it will
attempt to call `project.project_feature.access_level`.
6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is
made to the database.
7. This `SELECT` call returns nothing, and the user sees a 500 error.

By eager loading `project_feature`, we can ensure that we have a
consistent view and avoid records from being deleted later.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482

Denys Mishunov authored 5 years ago and Paul Slaughter committed 5 years ago

One exception: there is an existing MR for the current branch and the
branch is non-default and non-protected.

Extended mock_data for ide/stores to have different types of branches:
default, protected and regular

Cleaned new MR checkbox view

Scott Hampton authored 5 years ago and Mayra Cabrera committed 5 years ago

Oauth2 tokens are causing issues with mirroring
repos, because it effectively limits the number
of repos you can mirror. Personal Access
Tokens do not have this problem.

This change removes the OAuth2 option from
the import page for CI/CD only, and only
provides the personal access token form.

Devise checks before updating any of the authentication_keys if it
needs to clear the reset_password_tokens.

This should fix:
https://gitlab.com/gitlab-org/gitlab-ce/issues/42733 (Weak
authentication and session management)

Previously we asked a user to enter a new slug before taking them to
the Create Page page.

As a UX improvement, we now take them to a randomly generated URI so
they can begin creating their new page.

https://gitlab.com/gitlab-org/gitlab-ce/issues/46299

* Refactor some tests as well

Use buttons instead of links with javascript:void(0)

Brett Walker authored 5 years ago and Paul Slaughter committed 5 years ago

- Adds UI to configure in group and project settings
- Removes notification configuration for users when
disabled at group or project level

Felipe Artur authored 5 years ago and Jan Provaznik committed 5 years ago

Add feature specs for multiple issue boards for groups

Sarah Yasonik authored 5 years ago and Mayra Cabrera committed 5 years ago

https://gitlab.com/gitlab-org/gitlab-ce/issues/62971

Adds support for embedding specific charts from the
metrics dashboard. Expected parameters are dashboard,
title, group, and y_label.

Alex Buijs authored 5 years ago and Mayra Cabrera committed 5 years ago

This link is shown when a user tries to login with an unconfirmed
email address and the grace period has expired

It was originally returning 302 when the rate limit kicks in, because
using the the correct status code makes it easier to track rate limiting
events

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/65974

Querying all counts for the different search results in the same request
led to timeouts, so we now only calculate the count for the *current*
search results, and request the others in separate asynchronous calls.

With a time treshold of 4 seconds
and a firstname and lastname honeypot
input fields when signing up

- expand upwards
- expand downwards
- expand all

in both inline and parallel views

minghuan lei authored 5 years ago and Paul Slaughter committed 5 years ago

- only in blobs result

The githost.log name was often confused with GitHost.io. Rename this to
git_json.log to make it clear it's coming from Git and that it's JSON
data.

As decided in https://gitlab.com/gitlab-org/gitlab-ce/issues/53593

The invitation flow changed a bit, because now
there is no more need to sign in after confirming.
When signing up with a different email address,
the user will see the invitation page straight after
signing up when redirected, without needing to
sign in.

Don't redirect to the Almost there page after registration
and after resending confirmation instructions