Skip to content
Snippets Groups Projects
  1. Jul 30, 2018
  2. Jul 27, 2018
  3. Jul 26, 2018
  4. Jul 09, 2018
  5. Jul 03, 2018
    • Yorick Peterse's avatar
      Fixed pagination of web hook logs · f3008907
      Yorick Peterse authored
      For reasons unknown, the logs of a web hook were paginated in memory.
      This would result in the "Edit" page of a web hook timing out once it
      has more than a few thousand log entries.
      
      This commit makes the following changes:
      
      1. We use LIMIT/OFFSET to paginate the data, instead of doing this in
         memory.
      
      2. We limit the logs to the last two days, just like the documentation
         says (instead of retrieving everything).
      
      3. We change the indexes on "web_hook_logs" so the query to get the data
         can perform a backwards index scan, without the need for a Filter.
      
      These changes combined ensure that Projects::HooksController#edit no
      longer times out.
      Unverified
      f3008907
  6. Jun 25, 2018
  7. Jun 21, 2018
  8. Jun 20, 2018
  9. Jun 05, 2018
  10. May 31, 2018
  11. May 26, 2018
    • Stan Hu's avatar
      Fix fast admin counters not working when PostgreSQL has secondaries · b6125f70
      Stan Hu authored
      This commit does a number of things:
      
      1. Reduces the number of queries needed by perform a single query to get all
      the tuples for the relevant rows.
      
      2. Uses a transaction to query the tuple counts to ensure that the data
      is retrieved from the primary.
      
      Closes #46742
      b6125f70
  12. May 23, 2018
  13. May 16, 2018
  14. Apr 13, 2018
  15. Apr 11, 2018
    • blackst0ne's avatar
      [Rails5] Fix admin/application_settings_controller · ac1b5def
      blackst0ne authored
      The `RAILS5=1 rspec spec/controllers/admin/application_settings_controller_spec.rb`
      command throws the error:
      
      Failures:
      
        1) Admin::ApplicationSettingsController PUT #update falls back to defaults when settings are omitted
            Failure/Error: import_sources = params[:application_setting][:import_sources]
      
            NoMethodError:
              undefined method `[]' for nil:NilClass
            # ./app/controllers/admin/application_settings_controller.rb:62:in `application_setting_params'
      
      This commit fixes it.
      ac1b5def
  16. Apr 04, 2018
  17. Apr 02, 2018
  18. Mar 22, 2018
    • Toon Claes's avatar
      Add read-only banner to all pages · 9ab43aa7
      Toon Claes authored
      When the database is in a read-only state, display a banner on each
      page informing the user they cannot write to that GitLab instance.
      
      Closes gitlab-org/gitlab-ce#43937.
      9ab43aa7
  19. Mar 02, 2018
  20. Feb 27, 2018
  21. Feb 05, 2018
  22. Feb 02, 2018
  23. Feb 01, 2018
    • Yorick Peterse's avatar
      Track and act upon the number of executed queries · cca61980
      Yorick Peterse authored
      This ensures that we have more visibility in the number of SQL queries
      that are executed in web requests. The current threshold is hardcoded to
      100 as we will rarely (maybe once or twice) change it.
      
      In production and development we use Sentry if enabled, in the test
      environment we raise an error. This feature is also only enabled in
      production/staging when running on GitLab.com as it's not very useful to
      other users.
      Unverified
      cca61980
  24. Jan 31, 2018
    • Zeger-Jan van de Weg's avatar
      Gitaly Server info for admin panel · 94a3dbca
      Zeger-Jan van de Weg authored
      Implements the client side for gitlab-org/gitaly#819. Which is a server
      info command. This checks the server version and git binairy version on
      the server.
      
      A small UI was added for administrators, so they can check the status of
      the Gitaly server. This is done for each storage the monolith knows.
      
      Because of this commit, gitlab-org/gitlab-ce!15580 is now closed. That
      MR removed the Git version too, but didn't replace it with anything.
      Unverified
      94a3dbca
  25. Jan 18, 2018
  26. Jan 17, 2018
  27. Jan 11, 2018
  28. Jan 08, 2018
  29. Dec 12, 2017
  30. Dec 08, 2017
    • Bob Van Landuyt's avatar
      Move the circuitbreaker check out in a separate process · f1ae1e39
      Bob Van Landuyt authored
      Moving the check out of the general requests, makes sure we don't have
      any slowdown in the regular requests.
      
      To keep the process performing this checks small, the check is still
      performed inside a unicorn. But that is called from a process running
      on the same server.
      
      Because the checks are now done outside normal request, we can have a
      simpler failure strategy:
      
      The check is now performed in the background every
      `circuitbreaker_check_interval`. Failures are logged in redis. The
      failures are reset when the check succeeds. Per check we will try
      `circuitbreaker_access_retries` times within
      `circuitbreaker_storage_timeout` seconds.
      
      When the number of failures exceeds
      `circuitbreaker_failure_count_threshold`, we will block access to the
      storage.
      
      After `failure_reset_time` of no checks, we will clear the stored
      failures. This could happen when the process that performs the checks
      is not running.
      f1ae1e39
  31. Dec 04, 2017
  32. Nov 02, 2017
Loading