Skip to content
Snippets Groups Projects
  1. Jul 26, 2018
  2. Jun 05, 2018
  3. May 23, 2018
  4. May 16, 2018
    • Jan Provaznik's avatar
      Changed order of include · 32e22468
      Jan Provaznik authored
      32e22468
    • Jan Provaznik's avatar
      Delete remote uploads · 7da3b2cd
      Jan Provaznik authored
      ObjectStore uploader requires presence of associated `uploads` record
      when deleting the upload file (through the carrierwave's after_commit
      hook) because we keep info whether file is LOCAL or REMOTE in `upload`
      object.
      
      For this reason we can not destroy uploads as "dependent: :destroy" hook
      because these would be deleted too soon. Instead we rely on
      carrierwave's hook to destroy `uploads` in after_commit hook.
      
      But in before_destroy hook we still have to delete not-mounted uploads
      (which don't use carrierwave's destroy hook). This has to be done in
      before_Destroy instead of after_commit because `FileUpload` requires
      existence of model's object on destroy action.
      
      This is not ideal state of things, in a next step we should investigate
      how to unify model dependencies so we can use same workflow for all
      uploads.
      
      Related to #45425
      7da3b2cd
  5. Apr 05, 2018
  6. Mar 01, 2018
  7. Feb 28, 2018
  8. Feb 01, 2018
  9. Dec 04, 2017
  10. Aug 10, 2017
    • Yorick Peterse's avatar
      Cache Appearance instances in Redis · 26bb5041
      Yorick Peterse authored
      This caches the result of Appearance.first in a similar fashion to how
      ApplicationSetting instances are cached. We also add some NOT NULL
      constraints to the table and correct the timestamp types.
      
      Fixes gitlab-org/gitlab-ce#36066, fixes gitlab-org/gitlab-ce#31698
      Verified
      26bb5041
  11. Jul 06, 2017
    • Yorick Peterse's avatar
      Added Cop to blacklist the use of `dependent:` · 8fbbf41e
      Yorick Peterse authored
      This is allowed for existing instances so we don't end up 76 offenses
      right away, but for new code one should _only_ use this if they _have_
      to remove non database data. Even then it's usually better to do this in
      a service class as this gives you more control over how to remove the
      data (e.g. in bulk).
      Verified
      8fbbf41e
  12. Mar 06, 2017
  13. Oct 07, 2016
    • Nick Thomas's avatar
      Add markdown cache columns to the database, but don't use them yet · e94cd6fd
      Nick Thomas authored
      This commit adds a number of _html columns and, with the exception of Note,
      starts updating them whenever the content of their partner fields changes.
      
      Note has a collision with the note_html attr_accessor; that will be fixed later
      
      A background worker for clearing these cache columns is also introduced - use
      `rake cache:clear` to set it off. You can clear the database or Redis caches
      separately by running `rake cache:clear:db` or `rake cache:clear:redis`,
      respectively.
      e94cd6fd
  14. Jun 03, 2016
  15. May 09, 2016
  16. May 06, 2016
  17. Feb 26, 2016
    • Zeger-Jan van de Weg's avatar
      Branded login page also in CE · 9a2869ab
      Zeger-Jan van de Weg authored
      The only major difference with the EE version is the change from a light and dark logo to only a header logo
      The dark logo wasn't used anyway, so it seemed to make sense to me to rename the field to the actual function of it
      9a2869ab
Loading