- Jul 26, 2018
-
-
gfyoung authored
Partially addresses #47424.
-
- May 17, 2018
-
-
Yorick Peterse authored
When displaying the pipelines of a project we now preload the following data: 1. Authors of the commits that belong to these pipelines 2. The number of warnings per pipeline, which is used by Ci::Pipeline#has_warnings? == Commit Authors Previously this data was queried for every Commit separately, leading to 20 SQL queries being executed in the worst case. With an average of 3 to 5 milliseconds per SQL query this could result in 100 milliseconds being spent in _just_ getting Commit authors. To preload this data Commit#author now uses BatchLoader (through Commit#lazy_author), and a separate module Gitlab::Ci::Pipeline::Preloader is used to ensure all authors are loaded before they are used. == Number of warnings This changes Ci::Pipeline#has_warnings? so it supports preloading of the number of warnings per pipeline. This removes the need for executing a COUNT(*) query for every pipeline just to see if it has any warnings or not.
-
- May 01, 2018
-
-
- Apr 29, 2018
-
-
blackst0ne authored
This commit fixes errors like: ``` 1) API::Todos GET /todos when unauthenticated returns authentication error Failure/Error: @raw.__send__(method, *args, &block) # rubocop:disable GitlabSecurity/PublicSend NoMethodError: undefined method `touch_later' for #<Gitlab::Git::Commit:0x00005573f5196270> # ./app/models/commit.rb:259:in `method_missing' # ./spec/requests/api/todos_spec.rb:12:in `block (2 levels) in <top (required)>' ```
-
- Apr 19, 2018
-
-
Stan Hu authored
We saw about 10,000 SQL queries for some commits in the NewNoteWorker, which stalled the Sidekiq queue for other new notes. The notification service took up to 8 minutes to process the commits. Avoiding this N+1 query brings the time down significantly. Closes #45526
-
- Apr 06, 2018
-
-
Oswaldo Ferreir authored
-
- Apr 04, 2018
-
-
- Mar 26, 2018
-
-
YarNayar authored
Closes #23460
-
- Mar 06, 2018
-
-
Zeger-Jan van de Weg authored
-
- Mar 01, 2018
-
-
Ahmad Sherif authored
Closes gitaly#1046
-
- Feb 16, 2018
-
-
Micael Bergeron authored
When a merge request is merged, it creates a commit with the description of the MR, which may contain references and issue closing references. As this will be handled in the PostMergeService anyways, let's ignore merge commit generated from a MR.
-
- Feb 14, 2018
-
-
Jarka Kadlecova authored
-
- Jan 15, 2018
-
-
Ahmad Sherif authored
Closes gitaly#915
-
- Jan 12, 2018
-
-
Hiroyuki Sato authored
-
Sean McGivern authored
If we search for notes before the MR was merged, we have to load every commit that was ever part of the MR, or mentioned in a push. In extreme cases, this can be tens of thousands of commits to load, but we know they can't revert the merge commit, because they are from before the MR was merged. In the (rare) case that we don't have a `merged_at` value for the MR, we can still search all notes.
-
- Jan 04, 2018
-
-
Jacob Vosmaer (GitLab) authored
-
- Dec 19, 2017
-
-
Zeger-Jan van de Weg authored
Uses `list_commits_by_oid` on the CommitService, to request the needed commits for pipelines. These commits are needed to display the user that created the commit and the commit title. This includes fixes for tests failing that depended on the commit being `nil`. However, now these are batch loaded, this doesn't happen anymore and the commits are an instance of BatchLoader.
-
- Dec 13, 2017
-
-
Jacopo authored
Allows ordering in GET api/v4/projects/:project_id/repository/contributors through `order_by` and `sort` params. The available `order_by` options are: name|email|commits. The available `sort` options are: asc|desc.
-
- Dec 07, 2017
-
-
micael.bergeron authored
-
- Nov 23, 2017
-
-
Jarka Kadlecova authored
-
- Nov 21, 2017
-
-
Zeger-Jan van de Weg authored
After installing a new gem, batch-loader, a construct can be used to queue data to be fetched in bulk. The gem was also introduced in both gitlab-org/gitlab-ce!14680 and gitlab-org/gitlab-ce!14846, but those mrs are not merged yet. For the generation of diffs, both the old blob and the new blob need to be loaded. This for every file in the diff, too. Now we collect all these so we do 1 fetch. Three `.allow_n_plus_1_calls` have been removed, which I expect to be valid, but this needs to be confirmed by a full CI run. Possibly closes: - https://gitlab.com/gitlab-org/gitlab-ce/issues/37445 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37599 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37431
-
- Nov 16, 2017
-
-
Yorick Peterse authored
This adds an optimised way of getting the latest pipeline status for a list of Commit objects (or just a single one).
-
micael.bergeron authored
-
- Nov 15, 2017
-
-
micael.bergeron authored
-
micael.bergeron authored
-
- Sep 25, 2017
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- Sep 06, 2017
-
-
Tiago Botelho authored
-
- Sep 05, 2017
-
-
Alexis Reigel authored
we need the commit object for the updated verification that also checks the committer's email to match the gpg key and user's emails.
-
- Aug 21, 2017
-
-
Saverio Miroddi authored
-
Saverio Miroddi authored
Also improved the UT for better documenting this change.
-
- Aug 17, 2017
-
-
Saverio Miroddi authored
The list of commits must be generated from the merge request, not from a diff of the branches.
-
- Aug 16, 2017
-
-
Douwe Maan authored
-
- Aug 15, 2017
-
-
Saverio Miroddi authored
-
Saverio Miroddi authored
Follow the `cherry pick -x` format for the first line, and the interactive rebase format for the commits in the merge, in case of merge commit
-
Saverio Miroddi authored
This also fixes the inconsistency between non/merge commits in the number of newlines introduced.
-
- Aug 14, 2017
-
-
Robert Speicher authored
An upcoming update to rubocop-gitlab-security added additional violations.
-
- Aug 10, 2017
-
-
Saverio Miroddi authored
Store the original commit in the commit message. In case of merge commit, the commits added to the start branch are also listed.
-
- Aug 08, 2017
-
-
Alejandro Rodríguez authored
This helps keep the abstraction layers simpler, and also keep the interface of those methods consistent, in case of implementation changes.
-
Alejandro Rodríguez authored
-