- Jul 26, 2018
-
-
gfyoung authored
Partially addresses #47424.
-
- May 24, 2018
-
-
Oswaldo Ferreir authored
We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response. With this change we solve this problem and simplify a lot fetching this piece of info.
-
- Apr 30, 2018
-
-
Oswaldo Ferreir authored
Today, when fetching diffs of a note, we always go to Gitaly in order to diff between commits and return the diff of each discussion note. With this change we avoid doing that for notes on the "current version" of the MR.
-
- Dec 22, 2017
-
-
Douwe Maan authored
Improve performance of DiffDiscussion#truncated_diff_lines and DiffNote#diff_line by removing expensive diff position calculation and comparison
-
- Dec 07, 2017
-
-
Douwe Maan authored
-
- Nov 13, 2017
-
-
Felipe Artur authored
-
- Oct 07, 2017
-
-
- Jul 06, 2017
-
-
Yorick Peterse authored
This cop has been renamed to ActiveRecordSerialize to match the way "ActiveRecord" is usually written.
-
- May 31, 2017
-
-
Douwe Maan authored
-
Yorick Peterse authored
This Cop blacklists the use of ActiveRecord's "serialize" method, except for cases where we already use this.
-
- May 23, 2017
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- May 03, 2017
-
-
Douwe Maan authored
-
- Apr 08, 2017
-
-
Douwe Maan authored
-
- Apr 06, 2017
-
-
Douwe Maan authored
-
- Apr 05, 2017
-
-
- Feb 23, 2017
-
-
Douwe Maan authored
-
- Sep 06, 2016
-
-
Alejandro Rodríguez authored
Use `update_all` to only require one query per discussion to update the notes resolved status. Some changes had to be made to the discussion spec to accout for the fact that notes are not individually updated now
-
- Aug 30, 2016
-
-
Sean McGivern authored
-
- Aug 22, 2016
-
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- Aug 19, 2016
-
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
- Aug 17, 2016
-
-
Connor Shea authored
-
Douwe Maan authored
-
- Aug 16, 2016
-
-
Douwe Maan authored
-
- Aug 15, 2016
-
-
Dmitriy Zaporozhets authored
Signed-off-by:
Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- Aug 12, 2016
-
-
Sean McGivern authored
An MR can only be resolved in the UI if: - It has conflicts. - It has valid diff_refs (in other words, it supports new diff notes). - It has no conflicts with one side missing. - It has no conflicts in binary files. - It has no conflicts in files too large to display. - It has no conflicts containing invalid conflict markers.
-
Douwe Maan authored
-
- Aug 02, 2016
-
-
Paco Guzman authored
Speedup DiffNote#active? on discussions, preloading noteables and avoid touching git repository to return diff_refs when possible - Preloading noteable we share the same noteable instance when more than one discussion refers to the same noteable. - Any other call to that object that is cached in that object will be for any discussion. - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that diff_refs using directly those sha instead accessing to the git repository to first get the commits and later the sha.
-
- Jul 29, 2016
-
-
Douwe Maan authored
-
- Jul 26, 2016
-
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
- Jul 07, 2016
-
-
Douwe Maan authored
-
- Jul 06, 2016
-
-
Douwe Maan authored
-