Skip to content
Snippets Groups Projects
  1. Jul 26, 2018
  2. Jan 17, 2018
  3. Nov 13, 2017
  4. Nov 11, 2017
  5. Jul 07, 2017
  6. May 04, 2017
  7. Mar 10, 2017
  8. Feb 23, 2017
  9. Jan 06, 2017
  10. Dec 20, 2016
  11. Nov 23, 2016
  12. Oct 07, 2016
    • Nick Thomas's avatar
      Add markdown cache columns to the database, but don't use them yet · e94cd6fd
      Nick Thomas authored
      This commit adds a number of _html columns and, with the exception of Note,
      starts updating them whenever the content of their partner fields changes.
      
      Note has a collision with the note_html attr_accessor; that will be fixed later
      
      A background worker for clearing these cache columns is also introduced - use
      `rake cache:clear` to set it off. You can clear the database or Redis caches
      separately by running `rake cache:clear:db` or `rake cache:clear:redis`,
      respectively.
      e94cd6fd
  13. Sep 23, 2016
  14. Mar 29, 2016
  15. Mar 07, 2016
  16. Mar 05, 2016
  17. Jan 08, 2016
  18. Jan 07, 2016
  19. Dec 22, 2015
  20. Dec 07, 2015
  21. Dec 05, 2015
    • Stan Hu's avatar
      Fix Error 500 when creating global milestones with Unicode characters · d800a949
      Stan Hu authored
      Two issues:
      
      1. The constraints in the resources were incorrect. Here's what it was before:
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      In this case, id is actually the title of the milestone, which can be anything at the moment.
      
      After:
      
      ```
      group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
      ```
      
      2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
      
      ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
      
      This change uses the babosa library to create a better slug, which surprisingly
      isn't actually used by the global milestone controllers. Instead, they use the
      title passed as a query string for some reason.
      
      Closes https://github.com/gitlabhq/gitlabhq/issues/9881
      
      Fix constraints
      d800a949
  22. Dec 03, 2015
  23. Nov 16, 2015
  24. Oct 14, 2015
  25. Oct 09, 2015
  26. May 26, 2015
    • Jonah Bishop's avatar
      Change percent_complete rescue value from 100 to 0 · 8b92946b
      Jonah Bishop authored
      The percent_complete method returns a value of 100 when a
      ZeroDivisionError occurs. That seems like a very strange default for an
      error case, and results in a bug when a milestone has no corresponding
      issues (new, empty milestones show 100% completion). This commit changes
      the rescue value to 0, and subsequently fixes #1656, which reported this
      problem.
      8b92946b
Loading