Skip to content
Snippets Groups Projects
  1. Jul 26, 2018
  2. Jul 11, 2018
  3. Jul 03, 2018
  4. Jun 07, 2018
  5. Jun 06, 2018
  6. May 16, 2018
    • Jan Provaznik's avatar
      Changed order of include · 32e22468
      Jan Provaznik authored
      32e22468
    • Jan Provaznik's avatar
      Delete remote uploads · 7da3b2cd
      Jan Provaznik authored
      ObjectStore uploader requires presence of associated `uploads` record
      when deleting the upload file (through the carrierwave's after_commit
      hook) because we keep info whether file is LOCAL or REMOTE in `upload`
      object.
      
      For this reason we can not destroy uploads as "dependent: :destroy" hook
      because these would be deleted too soon. Instead we rely on
      carrierwave's hook to destroy `uploads` in after_commit hook.
      
      But in before_destroy hook we still have to delete not-mounted uploads
      (which don't use carrierwave's destroy hook). This has to be done in
      before_Destroy instead of after_commit because `FileUpload` requires
      existence of model's object on destroy action.
      
      This is not ideal state of things, in a next step we should investigate
      how to unify model dependencies so we can use same workflow for all
      uploads.
      
      Related to #45425
      7da3b2cd
  7. May 04, 2018
  8. May 02, 2018
  9. Apr 23, 2018
  10. Apr 18, 2018
    • Yorick Peterse's avatar
      Revert the addition of goldiloader · 6f292eaa
      Yorick Peterse authored
      This reverts the addition of the "goldiloader" Gem and all use of it.
      While this Gem is very promising it's causing a variety of problems on
      GitLab.com due to it eager-loading too much data in places where we
      don't expect/can handle this. At least for the time being this means we
      have to go back to manually fixing N+1 query problems, but at least
      those should not cause a negative impact on availability.
      Verified
      6f292eaa
  11. Apr 09, 2018
  12. Apr 06, 2018
  13. Apr 04, 2018
  14. Mar 22, 2018
  15. Mar 21, 2018
  16. Mar 05, 2018
  17. Mar 03, 2018
  18. Feb 28, 2018
  19. Feb 22, 2018
  20. Feb 05, 2018
  21. Feb 01, 2018
  22. Dec 07, 2017
  23. Dec 05, 2017
  24. Dec 01, 2017
  25. Nov 24, 2017
  26. Nov 23, 2017
  27. Nov 06, 2017
  28. Nov 03, 2017
Loading