Skip to content
Snippets Groups Projects
  1. Jul 26, 2018
  2. Jun 07, 2018
    • Felipe Artur's avatar
    • Sean McGivern's avatar
      Fix some N+1s when calculating notification recipients · 0206476a
      Sean McGivern authored
      First N+1: we may have loaded a user's notification settings already, but not
      have loaded their sources. Because we're iterating through, we'd potentially
      load sources that are completely unrelated, just because they belong to this
      user.
      
      Second N+1: we do a separate query for each user who could be subscribed to or
      unsubcribed from the target. It's actually more efficient in this case to get
      all subscriptions at once, as we will need to check most of them.
      
      We can fix both by the slightly unpleasant means of checking IDs manually,
      rather than object equality.
      0206476a
  3. Apr 18, 2018
  4. Mar 26, 2018
  5. Mar 19, 2018
  6. Feb 22, 2018
  7. Jan 17, 2018
    • Mario de la Ossa's avatar
      Initial work to add notification reason to emails · 23a20c20
      Mario de la Ossa authored
      Adds `#build_notification_recipients` to `NotificationRecipientService`
      that returns the `NotificationRecipient` objects in order to be able to
      access the new attribute `reason`.
      
      This new attribute is used in the different notifier methods in order to
      add the reason as a header: `X-GitLab-NotificationReason`.
      
      Only the reason with the most priority gets sent.
      Unverified
      23a20c20
  8. Jan 11, 2018
  9. Aug 21, 2017
    • http://jneen.net/'s avatar
      don't rely on order of notification levels · 3676275a
      http://jneen.net/ authored
      factor out #suitable_notification_level? and check manually by
      notification level. this makes the notification logic clear and actually
      reflect what is in the documentation as to what should happen with each
      setting.
      3676275a
  10. Aug 11, 2017
  11. Aug 03, 2017
Loading