Save few lines of code with Merge Request comment like github does

Created by: dzaporozhets

Created by: seeingidog

I am uncertain what this means after looking over Github's pull request interface closely. Could you elaborate or show an example?

By Administrator on 2012-07-20T21:06:12 (imported from GitLab project)

By Administrator on 2012-07-20T21:06:12 (imported from GitLab)

Created by: dzaporozhets

Yeap. like this one

By Administrator on 2012-07-20T21:12:01 (imported from GitLab project)

By Administrator on 2012-07-20T21:12:01 (imported from GitLab)

Created by: dzaporozhets

so when we on tab comments we can see some code with inline comment

By Administrator on 2012-07-20T21:12:49 (imported from GitLab project)

By Administrator on 2012-07-20T21:12:49 (imported from GitLab)

Created by: mkrauser

this would be really nice. At the moment there's no indication at all that a comment is placed within the code. A code-snippet like suggested plus a link to the coresponding line in the diff-tab would be a great improvement.

By Administrator on 2012-07-24T07:13:03 (imported from GitLab project)

By Administrator on 2012-07-24T07:13:03 (imported from GitLab)

Created by: AlexDenisov

That would be great and very useful, e.g. for code review.

By Administrator on 2012-09-10T06:28:10 (imported from GitLab project)

By Administrator on 2012-09-10T06:28:10 (imported from GitLab)

Created by: kennytm

I hope this is actually saving the few lines of code from the diff, instead of just copying the lines from the line number of the comment. The content of a merge request can change once the submitter pushed new commits, which then all comments become useless since the context becomes different.

By Administrator on 2012-11-12T17:39:59 (imported from GitLab project)

By Administrator on 2012-11-12T17:39:59 (imported from GitLab)

Created by: therma

+1

By Administrator on 2013-02-16T10:36:03 (imported from GitLab project)

By Administrator on 2013-02-16T10:36:03 (imported from GitLab)