Creation and removal of symbolic links are not shown in commits.

Created by: kennytm

Steps to reproduce:

1. Create a symbolic link, and add this to a commit.

   ln -s whatever symlink
   git add symlink
   git commit
   git push origin master

2. Check the commit on GitLab. One will find the commit is empty, showing 0 changes.

Interestingly this does not affects the Diff tab in merge requests.

Created by: kouno

After investigating, I think it is related to Grit not going through symlinks when doing a diff.

In Grit::GitRuby::Repository#diff, it bases the diff on #quickdiff, which itself looks like this:

      def quick_diff(tree1, tree2, path = '.', recurse = true)
        # handle empty trees
        changed = []
        return changed if tree1 == tree2

        t1 = list_tree(tree1) if tree1
        t2 = list_tree(tree2) if tree2

        # finding files that are different
        t1['blob'].each do |file, hsh|
        #... some comparison code here
        end
        t2['blob'].each do |file, hsh|
        #... some comparison code here
        end

        t1['tree'].each do |dir, hsh|
        #... some comparison code here
        end
        t2['tree'].each do |dir, hsh|
        #... some comparison code here
        end

        changed
      end

Basically list_tree returns blob, tree, and symlinks, but symlinks are never compared afterwards and there seems to be no option to activate it.

I believe it should be fix at the grit level... Or we could use a workaround...

By Administrator on 2012-10-03T01:28:15 (imported from GitLab project)

By Administrator on 2012-10-03T01:28:15 (imported from GitLab)

Created by: dzaporozhets

thank you for provided PR

By Administrator on 2013-02-25T17:52:31 (imported from GitLab project)

By Administrator on 2013-02-25T17:52:31 (imported from GitLab)