hardcoded path for post-receive hook fs-exists check should not fatal gitlab:app:status
Created by: damianb
Considering that a multitude of people (including myself) frown upon the use of /home/ for serving anything out of, and instead prefer other locations within the filesystem for locating servers (such as /srv/), it should be expected that the post-receive hook may not exist there.
Throwing a fatal error when it does not exist there is useless in circumstances like my own.
A better alternative would be a warning, IMO - "We don't think this is right - check this unless you know what you're doing" would be far better than "File does not exist, return 1 and BAIL OUT"
Activity
Created by: LeonB
The post-receive hooks are hardcoded:
gitlab.mydomain.tld@gitlab:~/public_html$ bundle exec rake gitlab:app:status RAILS_ENV=production Starting diagnostic config/database.yml............exists config/gitlab.yml............exists /var/lib/gitolite/repositories/............exists /var/lib/gitolite/repositories/ is writable?............YES remote: Counting objects: 273, done. remote: Compressing objects: 100% (210/210), done. remote: Total 273 (delta 74), reused 0 (delta 0) Receiving objects: 100% (273/273), 22.48 KiB, done. Resolving deltas: 100% (74/74), done. Can clone gitolite-admin?............YES UMASK for .gitolite.rc is 0007? ............YES /home/gitolite/share/gitolite/hooks/common/post-receive exists? ............NO rake aborted!While my hooks are actually in:
/var/lib/gitolite/.gitolite/hooks/common/(Ubuntu default)By Administrator on 2012-08-24T23:05:59 (imported from GitLab project)
By Administrator on 2012-08-24T23:05:59 (imported from GitLab)
Created by: sroth80021
I ran into this as well (but only remember seeing it with 2.8 -- perhaps it didnt happen in 2.7) -- in my case, the files were at /scratch/git/.gitolite/hooks/common
I looked, but didnt see a place in the config/gitlab.yml file to specify where the gitolite install was located at.
By Administrator on 2012-08-26T19:34:24 (imported from GitLab project)
By Administrator on 2012-08-26T19:34:24 (imported from GitLab)
Created by: dzaporozhets
Hey guys. Gitolite have 2 places to store hooks. We use share dir for hooks.
From docs:
# update gitolite hooks sudo cp ./lib/hooks/post-receive /home/git/share/gitolite/hooks/common/post-receive sudo chown git:git /home/git/share/gitolite/hooks/common/post-receiveI cant write script to cover all cases. Only main one when you install gitolite from gitlab repo.
So just ignore app:status in your case if you know you placed hooks manually
By Administrator on 2012-08-27T18:59:26 (imported from GitLab project)
By Administrator on 2012-08-27T18:59:26 (imported from GitLab)
Created by: sroth80021
yeah, I noticed this yesterday as well. apologies; I used yum to install gitolite 2 when I did my gitlab install, and that seems to be why I ran into this.
By Administrator on 2012-08-27T19:19:04 (imported from GitLab project)
By Administrator on 2012-08-27T19:19:04 (imported from GitLab)
Created by: damianb
@randx - regardless, it shouldn't be a fatal error on the app:status check. if there's checks after that, they become useless to anyone not using gitolite straight from their git repo (which when I was installing gitlab, it was recommended to install straight out of gitolite's master branch for some insane reason)
By Administrator on 2012-08-27T23:43:28 (imported from GitLab project)
By Administrator on 2012-08-27T23:43:28 (imported from GitLab)
Created by: dzaporozhets
@damianb I think if you install gitolite not from gitlab - you know what you do. In this case you dont need to be bother about all this checks. Guys I dont have resources to cover all cases.
Thats why @vsizov writed installation doc & we write stuff related to this docs. If you know how handle it - you can provide a PR. Thats FOSS. Help from community is appreciated.
By Administrator on 2012-08-28T07:37:47 (imported from GitLab project)
By Administrator on 2012-08-28T07:37:47 (imported from GitLab)
Created by: LeonB
I've made a pull request: https://github.com/gitlabhq/gitlabhq/pull/1313 Hope it's OK!
By Administrator on 2012-08-28T09:00:49 (imported from GitLab project)
By Administrator on 2012-08-28T09:00:49 (imported from GitLab)
