urlencode filenames
Created by: schachmat
when committing a file with a carriage return \r in the filename, the carriage return is omitted in the url to view the file in gitlab. with urlencode the file can be viewed.
example:
name a file "the\rgame". create the carriage return in shell with ctrl+v and returnkey and commit it. gitlab links the file as "thegame". the correct link would be "the%0dgame" and this one works.
Activity
Created by: sullivanpt
This issue extends beyond newlines to all characters which should be url encoded, for example I just encountered errors attempting to browse files after committing file and folder names containing plus characters '+'. Example:
Request URL:http://lvh.me/root/pim2/tree/master/c++.txt?_=1234567890 Request Method:GET Status Code:404 Not Found
Perhaps the RHS of the or conditional argument to project_tree_path in app/views/tree/_tree_item.html.haml needs url encoding?
By Administrator on 2013-04-23T08:00:30 (imported from GitLab project)
By Administrator on 2013-04-23T08:00:30 (imported from GitLab)
Created by: bbodenmiller
Still an issue in 5.1? I seem to recall there is some similar issues to this that relate to the project name and the URL that results in.
By Administrator on 2013-05-19T00:00:16 (imported from GitLab project)
By Administrator on 2013-05-19T00:00:16 (imported from GitLab)
Created by: bbodenmiller
It's been atleast 2 weeks since we heard from you. I'm closing this issue but if you still experience this problem, please open a new issue (but also reference the old issue(s)). Make sure to also include the necessary debugging information conforming to the issue tracker guidelines found in our contributing guidelines.
By Administrator on 2013-06-10T00:12:13 (imported from GitLab project)
By Administrator on 2013-06-10T00:12:13 (imported from GitLab)
