Feature Request : Protecting branches through the API

Created by: yuters

So far automating the process of creating a project/repo and setting up our workflow has been a breeze with the Gitlab API. The only thing missing would be the possibility to protect the stable (or any) branch for the owner. But maybe there's another way to do so (automatically) ?

Created by: m4tthumphrey

This is essential. Wish I was a ruby god, I'd be hacking away!

By Administrator on 2012-11-23T16:18:06 (imported from GitLab project)

By Administrator on 2012-11-23T16:18:06 (imported from GitLab)

Created by: m4tthumphrey

@yuters, I have hacked it enough to get it working how I need:

/lib/api/projects.rb

post ":id/repository/branches/:branch/protect" do
  user_project.protected_branches.create(:name => params[:branch])
  @branch = user_project.repo.heads.find { |item| item.name == params[:branch] }
  present @branch, with: Entities::RepoObject
end

I'm not a ruby man so make of it what you will, does the job I need it to. Would be nice to see a proper interface for (un)protecting branches, and a protected attribute in the Branch hash.

By Administrator on 2012-11-27T14:41:17 (imported from GitLab project)

By Administrator on 2012-11-27T14:41:17 (imported from GitLab)

Created by: yuters

I'll try it out, thanks a lot!

By Administrator on 2012-11-27T15:12:46 (imported from GitLab project)

By Administrator on 2012-11-27T15:12:46 (imported from GitLab)

Created by: riyad

/cc @vsizov @randx would be cool :)

By Administrator on 2012-11-28T14:18:27 (imported from GitLab project)

By Administrator on 2012-11-28T14:18:27 (imported from GitLab)

Created by: dzaporozhets

yes i think it might be useful. I'll add accepting PR tag

By Administrator on 2012-11-28T15:16:09 (imported from GitLab project)

By Administrator on 2012-11-28T15:16:09 (imported from GitLab)

Created by: mphuff

@m4tthumphrey -- Have you opened a pull request to add this in to Gitlab yet? I too am interested in the same functionality. I agree with all of your suggested improvements per the code you posted above.

Thanks, Micah

By Administrator on 2013-01-17T19:41:53 (imported from GitLab project)

By Administrator on 2013-01-17T19:41:53 (imported from GitLab)

Created by: m4tthumphrey

@mphuff No I haven't created a PR because I'm not comfortable enough with Ruby yet, I only added that code to get what I needed out of it. Would need to add a test and I don't know my contribution is good enough/implemented correctly. Feel free to take it and make a PR out of it though!

Also this doesn't provide functionality to unprotect a branch.

By Administrator on 2013-01-17T20:04:55 (imported from GitLab project)

By Administrator on 2013-01-17T20:04:55 (imported from GitLab)

Created by: m4tthumphrey

@mphuff PR is open! #2839

By Administrator on 2013-01-29T23:01:12 (imported from GitLab project)

By Administrator on 2013-01-29T23:01:12 (imported from GitLab)

Created by: yuters

I guess we can close this now. Thanks @m4tthumphrey

By Administrator on 2013-01-31T19:48:53 (imported from GitLab project)

By Administrator on 2013-01-31T19:48:53 (imported from GitLab)