ACE changing line endings in .SH file to DOS mode

Created by: petergus

i have some bash scripts in my repo and when i edit with the inline editor and then pull the changes to the server two strange things happen.

1. it replace ALL the text, not just the lines changed (git diff show all as minus and then adding back everything. i believe this is related to 2.
2. it changes the mode to dos. when i run the shell script again (after pulling the new changes) it get "/bin/bash^M: bad interpreter" running :set ff=unix in vim fixes it. also the permissions are changed (the file was 770 and after pull becomes something like 755)

all my machines involved are linux of mac so no chances to get dos. and for this example everything was happening on the server, ubuntu 10.04.

Created by: riyad

I'm sorry but I can't reproduce this. The editor's new line mode is set to "auto", so it should pick up whatever is used in the file.

You can check this by pasting the following line in the JS console when you have the edit page open: editor.getSession().getNewLineMode() (see the ACE docs for it)

By Administrator on 2012-12-17T17:54:24 (imported from GitLab project)

By Administrator on 2012-12-17T17:54:24 (imported from GitLab)

Created by: jojosch

i can confirm this behavior editor.getSession().getNewLineMode() is auto.

added a test.sh under linux. committed this file, edited the file in gitlab, pulled the changes, then running the file gives the error

before:

johannes@johannesDellXPS15:~/tmp/test
> ./test.sh                                                    master [f17d9da]
johannes

> git pull                                                     master [f17d9da]
remote: Counting objects: 5, done.
remote: Total 3 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
From code.js-webcoding.de:jojosch/test
   f17d9da..2fb023f  master     -> origin/master
Updating f17d9da..2fb023f
Fast-forward
 test.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

johannes@johannesDellXPS15:~/tmp/test
> ./test.sh                                                    master [2fb023f]
zsh: ./test.sh: bad interpreter: /bin/bash^M: no such file or directory

after setting as core.autocrlf gitlab user everything works as expected

git config --global core.autocrlf input

(reset the change, pushed, edited via gitlab)

> git pull                                                     master [f17d9da]
remote: Counting objects: 5, done.
remote: Total 3 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
From code.js-webcoding.de:jojosch/test
   f17d9da..814cf0a  master     -> origin/master
Updating f17d9da..814cf0a
Fast-forward
 test.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

johannes@johannesDellXPS15:~/tmp/test
> ./test.sh                                                    master [814cf0a]
Username: johannes

(the \n on the last line is removed after the edit)

By Administrator on 2012-12-17T18:34:29 (imported from GitLab project)

By Administrator on 2012-12-17T18:34:29 (imported from GitLab)

Created by: riyad

Updated the title

By Administrator on 2012-12-17T19:16:34 (imported from GitLab project)

By Administrator on 2012-12-17T19:16:34 (imported from GitLab)

Created by: vsizov

I've made all steps as described by @jojosch. I can't reproduce. Please provide git version on the server

By Administrator on 2013-01-02T18:04:03 (imported from GitLab project)

By Administrator on 2013-01-02T18:04:03 (imported from GitLab)

Created by: vsizov

@randx Can you try?

By Administrator on 2013-01-02T18:04:31 (imported from GitLab project)

By Administrator on 2013-01-02T18:04:31 (imported from GitLab)

Created by: vsizov

got it

By Administrator on 2013-01-02T18:08:43 (imported from GitLab project)

By Administrator on 2013-01-02T18:08:43 (imported from GitLab)

Created by: dabutcher

I can confirm this behavior. When using the GITLAB edit feature it defaults to CRLF line terminators, which breaks shell scripts.

GITLAB branch: 4-1-stable OS: Ubuntu 12.04.1 LTS

After editing a UNIX shell script in GITLAB's editor. $ file deploy.sh deploy.sh: Bourne-Again shell script, ASCII text executable, with CRLF line terminators

After applying the setting recommended by @jojosch files are now being created correctly for UNIX line terminators. And also resetting deploy.sh back to UNIX line terminators.

$ git config --global core.autocrlf input # for gitlab user Make edit to deploy.sh in GITLAB $ git pull $ file deploy.sh deploy.sh: Bourne-Again shell script, ASCII text executable

By Administrator on 2013-01-23T16:34:14 (imported from GitLab project)

By Administrator on 2013-01-23T16:34:14 (imported from GitLab)

Created by: dosire

Moved to http://feedback.gitlab.com/forums/176466-general/suggestions/3788036-the-online-editor-should-use-unix-style-line-endin

By Administrator on 2013-03-27T08:57:44 (imported from GitLab project)

By Administrator on 2013-03-27T08:57:44 (imported from GitLab)

Created by: mjdetullio

I tried the core.autocrlf = input trick and that breaks auto-merge on some projects, depending on the types of line endings in the files (just an FYI for others).

By Administrator on 2013-04-08T19:53:57 (imported from GitLab project)

By Administrator on 2013-04-08T19:53:57 (imported from GitLab)