Network graph broken in Gitlab 4.0

Created by: eyakcn

you can see 2 places broken in the picture:

1. The latest commit in master branch, front part is missing;
2. The latest commit in b2 branch, generate unnecessary line excess to the left side;

Created by: eyakcn

Rebase b1 and b2 branch onto master, and add one commit to master, you can see the problem more clearly. It seems the latest commit that break the graph, but b1 contains only 1 commit which does not break the graph.

By Administrator on 2013-01-04T08:19:57 (imported from GitLab project)

By Administrator on 2013-01-04T08:19:57 (imported from GitLab)

Created by: zjulzq

By Administrator on 2013-01-04T08:25:42 (imported from GitLab project)

By Administrator on 2013-01-04T08:25:42 (imported from GitLab)

Created by: zjulzq

For a branch except the latest one, if there are more than 2 commits ahead of base(ex, ticket-6057 in the previous picture), an additional line will connect the 1st commit to the left side, which is not expected to be there. Please refer to the previous picture.

By Administrator on 2013-01-04T08:31:13 (imported from GitLab project)

By Administrator on 2013-01-04T08:31:13 (imported from GitLab)

Created by: jbohren

Here's another one. Feel free to check this out here: http://github.com/jbohren/sandbox

By Administrator on 2013-01-18T22:23:18 (imported from GitLab project)

By Administrator on 2013-01-18T22:23:18 (imported from GitLab)

Created by: eyakcn

To mmoll,

It's another issue, not the same problem as this one.

By Administrator on 2013-01-20T00:39:32 (imported from GitLab project)

By Administrator on 2013-01-20T00:39:32 (imported from GitLab)

Created by: davispuh

something is broken with network graph, I'm just not sure what exactly...

I made repository with master branch and added few commits then made branch1 and added subtree to it from another repository.

Result in GitLab (really no clue WTF)

Same repository in Github (looks good)

By Administrator on 2013-01-20T04:14:45 (imported from GitLab project)

By Administrator on 2013-01-20T04:14:45 (imported from GitLab)

Created by: zjulzq

Please see this picture.

By Administrator on 2013-01-20T05:29:52 (imported from GitLab project)

By Administrator on 2013-01-20T05:29:52 (imported from GitLab)

Created by: veprbl

Reverting commits of vendor/assets/javascripts/branch-graph.js showed that there was a regression in a47032bc .

By Administrator on 2013-01-29T12:52:13 (imported from GitLab project)

By Administrator on 2013-01-29T12:52:13 (imported from GitLab)

Created by: veprbl

@koenpunt any ideas?

By Administrator on 2013-01-29T12:55:08 (imported from GitLab project)

By Administrator on 2013-01-29T12:55:08 (imported from GitLab)

Created by: jbohren

Here's what my above example (https://github.com/jbohren/sandbox) looks like for me in GitLab 4.1:

By Administrator on 2013-01-29T18:59:29 (imported from GitLab project)

By Administrator on 2013-01-29T18:59:29 (imported from GitLab)

Created by: hiroponz

Fixed by #2709.

After

By Administrator on 2013-01-30T02:31:39 (imported from GitLab project)

By Administrator on 2013-01-30T02:31:39 (imported from GitLab)

Created by: jbohren

@hiroponz Thanks!

By Administrator on 2013-01-30T02:41:04 (imported from GitLab project)

By Administrator on 2013-01-30T02:41:04 (imported from GitLab)

Created by: Razer6

@Riyad fixed, please close.

By Administrator on 2013-02-14T21:07:22 (imported from GitLab project)

By Administrator on 2013-02-14T21:07:22 (imported from GitLab)