remove link instead of 403 no access
Created by: tvb
If a user has no access to a page (ie commit page because user is type guest) remove the a href instead of showing 403 access denied page is much more user friendly imo. Therefore the link is not clickable at all.
Activity
Created by: tvb
Sure. If a user has 'guest' permissions. He is not able to view the actual commits as he is not allowed to view any code. But he is still able to click on the commit ID link and instead of viewing the changes and code he is redirected to the 403 not allowed page. My suggestion is to remove the link for 'guest' permissions al together so the user is not triggered to click a non-viewable commit and receive a useless page.
On Mon, Jan 7, 2013 at 7:56 PM, Riyad Preukschas notifications@github.comwrote:
Can you please be specific?
— Reply to this email directly or view it on GitHubhttps://github.com/gitlabhq/gitlabhq/issues/2495#issuecomment-11965065.
By Administrator on 2013-01-07T21:50:41 (imported from GitLab project)
By Administrator on 2013-01-07T21:50:41 (imported from GitLab)
Created by: tvb
@Riyad does the above make sense?
By Administrator on 2013-01-14T21:07:53 (imported from GitLab project)
By Administrator on 2013-01-14T21:07:53 (imported from GitLab)
Created by: riyad
@tristanvanbokkem I can't tell I've not yet come around to try it. ;) I'll answer as soon as I had the chance. ;)
By Administrator on 2013-01-14T21:14:12 (imported from GitLab project)
By Administrator on 2013-01-14T21:14:12 (imported from GitLab)
