check aborts with undefined method `path_to_repo' for nil:NilClass.

Created by: h0ru5

Upgrading 4.0 to 4.1 following https://github.com/gitlabhq/gitlabhq/wiki/From-4.0-to-4.1 one (example) user and repo is present running sudo -u gitlab -H bundle exec rake gitlab:check RAILS_ENV=production --trace leads to this error: https://gist.github.com/4637148

could be related to #2772 rsp. #2745 (closed) ?

Created by: pingupingu

What is the resolution to this? I have tried a rollback to the 4.0 version and the gitlab:check fails even more spectacularly... leaving me with no gitlab with either 4.1 or 4.0...

What is the fix for this?

By Administrator on 2013-01-27T18:57:33 (imported from GitLab project)

By Administrator on 2013-01-27T18:57:33 (imported from GitLab)

Created by: donnykurnia

@h0rus & @pingupingu I could start and access the gitlab. I don't know if the bug affect the repositories, because the check halt on another user's repository.

By Administrator on 2013-01-28T14:24:50 (imported from GitLab project)

By Administrator on 2013-01-28T14:24:50 (imported from GitLab)

Created by: donnykurnia

Hi all,

I decide to trace the error. The check is halted on a new project created just a few hours before I upgrade the gitlab from 4.0 to 4.1:

1.9.3p327 :001 > project = Project.last
  Project Load (160.3ms)  SELECT `projects`.* FROM `projects` ORDER BY `projects`.`id` DESC LIMIT 1
 => #<Project id: 112, name: "Projectname Front End Mockup", path: "projectname-front-end-mockup", description: nil, created_at: "2013-01-28 00:26:08", updated_at: "2013-01-28 00:26:08", private_flag: true, creator_id: 3, default_branch: nil, issues_enabled: true, wall_enabled: true, merge_requests_enabled: true, wiki_enabled: true, namespace_id: 3, public: false> 
1.9.3p327 :002 > project.path
 => "projectname-front-end-mockup" 
1.9.3p327 :003 > project.repository
  Namespace Load (232.2ms)  SELECT `namespaces`.* FROM `namespaces` WHERE `namespaces`.`id` = 3 LIMIT 1
 => nil 

The check script failed in this line (823)

project_hook_file = File.join(project.repository.path_to_repo, "hooks", hook_file)

Ok, I found out that the project have no repository yet. The team member just create that project, but haven't push anything yet to the project. I will try to add patch and add pull request so the empty repository skipped from the checking.

By Administrator on 2013-01-28T14:33:19 (imported from GitLab project)

By Administrator on 2013-01-28T14:33:19 (imported from GitLab)

Created by: h0ru5

@donnykurnia I also saw the relation to Projects from rails.

Since it was only toy data I could "repair" gitlab by initializing the db as written in install guide, but that's not a good workaround... Glad you narrowed the error down!

By Administrator on 2013-01-28T15:11:14 (imported from GitLab project)

By Administrator on 2013-01-28T15:11:14 (imported from GitLab)

Created by: donnykurnia

@h0ru5 The errors is because the project have empty repository. In satellite tasks, it check project.empty_repo? but not when checking hooks and try to fix the hooks. That's why it failed.

With the patch in #2803 I now could run gitlab:check successfully. It will show if the project have empty repository and stop trying to get the hooks.

I think this bug is exist since before 4.1, but just appear now when upgrading existing projects that happened to have empty repo.

By Administrator on 2013-01-29T06:50:50 (imported from GitLab project)

By Administrator on 2013-01-29T06:50:50 (imported from GitLab)