File or folder called "edit" inside a project will clash in with the web editor

Created by: yuters

I know that a good number of routing issue has been fixed already thanks to @hiroponz ( #3154 ) This one however probably clash with the appended /edit when using the web editor.

Created by: hiroponz

I can't reproduce. Please show the rails logs.

By Administrator on 2013-03-20T09:58:15 (imported from GitLab project)

By Administrator on 2013-03-20T09:58:15 (imported from GitLab)

Created by: yuters

Sorry the error was 404 before so I assumed it was still the problem because it's pretty much the same behavior as before. The rails logs has no error message.

Given I click on a folder called edit, the section showing the files will transition into the same folder. If I access it by using the url (tree/develop/views/admin/edit) it will notify "You can only edit text files"

Given I click on a file called edit.php, the section showing the files will transition into blank. If I access it by url ( tree/develop/views/admin/edit.php ) I will get to the file but with the web editor loaded.

By Administrator on 2013-03-20T11:28:03 (imported from GitLab project)

By Administrator on 2013-03-20T11:28:03 (imported from GitLab)

Created by: hiroponz

I have understood this problem. But it may be difficult to solve, because trailing "/edit" is a default routing path of rails. So I have no idea to solve this easily.

By Administrator on 2013-03-20T15:46:20 (imported from GitLab project)

By Administrator on 2013-03-20T15:46:20 (imported from GitLab)

Created by: yuters

Every other paths concerning a file will change the keywork in the url before the branch. ex : project/tree/master/myfile.ext project/blame/master/myfile.ext project/commits/master/myfile.ext

so to stay consistant I would use project/edit/master/myfile.ext instead of project/tree/master/myfile.ext/edit

I don't know if it would be difficult to implement as I'm not very familiar with Rails

By Administrator on 2013-03-21T12:46:13 (imported from GitLab project)

By Administrator on 2013-03-21T12:46:13 (imported from GitLab)

Created by: yuters

Buuuuut project/edit is already used

By Administrator on 2013-03-21T12:48:15 (imported from GitLab project)

By Administrator on 2013-03-21T12:48:15 (imported from GitLab)

Created by: hiroponz

Or project/editor/master/myfile.ext may be good solution. I'm not very familiar with rails too, studying now.

By Administrator on 2013-03-21T13:25:46 (imported from GitLab project)

By Administrator on 2013-03-21T13:25:46 (imported from GitLab)