Satellite generation broken in 5.0

Created by: davidolrik

I have just updated from 4.2 to 5.0 and I can't get Gitlab to generate the satellites.

When I run sudo -u git -H bundle exec rake gitlab:satellites:create RAILS_ENV=production, the output from the script tells me that it has created all the satellites, but only the namespace directories have been created.

In satellites.log I get this:

March 25, 2013 15:05: PID: 23: git clone /srv/dev/git/repositories/open-source/digest-dovecot-cram_md5.git /srv/dev/git/gitlab-satellites/open-source/digest-dovecot-cram_md5
March 25, 2013 15:05: PID: 23: -> Cloning into '/srv/dev/git/gitlab-satellites/open-source/digest-dovecot-cram_md5'...
error: cannot run git-upload-pack '/srv/dev/git/repositories/open-source/digest-dovecot-cram_md5.git': No such file or directory
fatal: unable to fork
March 25, 2013 15:05: Failed to create satellite for Open Source / Digest::Dovecot::CRAM_MD5

All my git binaries are located in /usr/bin, so they should be in $PATH.

Issue #3207 (closed) and #3203 (closed) might be related to this.

System information
System:         Ubuntu 12.04
Current User:   git
Using RVM:      no
Ruby Version:   1.9.3p392
Gem Version:    1.8.23
Bundler Version:unknown
Rake Version:   unknown

GitLab information
Version:        5.0.0
Revision:       0c7f426
Directory:      /srv/dev/git/gitlab
DB Adapter:     postgresql
URL:            https://git.host.com
HTTP Clone URL: https://git.host.com/some-project.git
SSH Clone URL:  git@git.host.com:some-project.git
Using LDAP:     no
Using Omniauth: no

GitLab Shell
Version:        1.2.0
Repositories:   /srv/dev/git/repositories/
Hooks:          /srv/dev/git/gitlab-shell/hooks/
Git:            /usr/bin/git

Created by: davidolrik

I have found the cause of my troubles!.

I'm running Gitlab under Nginx via Phusion Passenger , and in order to get git in $PATH, I added the following line to config/environment.rb

# Fix path so nginx has access to the git command
ENV['PATH'] = "/usr/bin";

That causes the satellite create task to fail.

Apparently the rake task needs more than /usr/bin

So I did a puts ENV['PATH'] in config/environment.rb, ran the rake task and changed my fix to the following based on the output of my puts command:

# Fix path so nginx has access to the git command
ENV['PATH'] = "/srv/dev/git/gitlab/vendor/bundle/ruby/1.9.1/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin";

And now everything works.

By Administrator on 2013-03-27T15:44:04 (imported from GitLab project)

By Administrator on 2013-03-27T15:44:04 (imported from GitLab)

Created by: zenbaku

As a note, I had the same problem, but caused by another thing.

In my case, gitlab couldn't clone the repositories because of a network host problem. The error was stated in satellites.log, so check that too if you can't figure out the reason.

By Administrator on 2013-05-03T18:57:34 (imported from GitLab project)

By Administrator on 2013-05-03T18:57:34 (imported from GitLab)