I linked the word Spinach in the README to the repo. I don't think we need to explain it further we don't link to every gem that the application uses. In my opinion a contributor should be able to find these docs.
By Administrator on 2013-05-03T07:16:02 (imported from GitLab project)
By Administrator on 2013-05-03T07:16:02 (imported from GitLab)
Currently the PR guidelines are very high-level. If we add such in-depth infos, we would also need to link to RSpec etc... I added a todo on my list to go through the Contribution Guidelines and see how detailed we want to be.
By Administrator on 2013-05-03T07:40:13 (imported from GitLab project)
By Administrator on 2013-05-03T07:40:13 (imported from GitLab)
Thanks for the feedkback. Being a ruby newbbie (and rails, spinach, etc also) i have spend a couple hours to get my test working.
If you follow the spinach docs, and do:
spinach -g
the features (already working) and your new .feature file, will be all generated inside steps/ folder, and i had to "clean" all those .rb files and leave my own, and moving it inside the steps/project subdirectory.
I dont know if this is "the way" to do it, or a gitlab dev should not use the spinach automatic generation at all?
Cheers!
By Administrator on 2013-05-03T11:35:28 (imported from GitLab project)
By Administrator on 2013-05-03T11:35:28 (imported from GitLab)