deleting and readding a protected branch

Created by: mcortecchia

Deleting and readding a protected branch will cause the "protected branches" area to become inaccessible

Created by: jimothyGator

I didn't find this to be the case. Instead, what I experienced was, if I deleted a protected branch, then went to the protected branches area, I got a 500. The way I fixed this was to re-add the protected branch, unprotected, then delete it again.

By Administrator on 2012-07-23T21:02:39 (imported from GitLab project)

By Administrator on 2012-07-23T21:02:39 (imported from GitLab)

Created by: jeromemacias

+1, I got the same issue

By Administrator on 2012-10-03T09:15:12 (imported from GitLab project)

By Administrator on 2012-10-03T09:15:12 (imported from GitLab)

Created by: mkorich

Agreed. We can cover temporarily via SOP but this needs fixing. :|

By Administrator on 2012-10-25T14:43:35 (imported from GitLab project)

By Administrator on 2012-10-25T14:43:35 (imported from GitLab)

Created by: dzaporozhets

I'll take a look

By Administrator on 2012-10-25T14:50:14 (imported from GitLab project)

By Administrator on 2012-10-25T14:50:14 (imported from GitLab)

Created by: timspin

+1, error from production.log:

Completed 500 Internal Server Error in 324ms

ActionView::Template::Error (undefined method id' for nil:NilClass): 39: - if branch.name == @project.root_ref 40: %span.label default 41: %td 42: = link_to project_commit_path(@project, branch.commit.id) do 43: = truncate branch.commit.id.to_s, length: 10 44: = time_ago_in_words(branch.commit.committed_date) 45: ago app/views/protected_branches/index.html.haml:42:inblock in _app_views_protected_branches_index_html_haml___529240135_85926150' app/views/protected_branches/index.html.haml:34:in each' app/views/protected_branches/index.html.haml:34:in_app_views_protected_branches_index_html_haml___529240135_85926150'

By Administrator on 2012-10-30T06:21:58 (imported from GitLab project)

By Administrator on 2012-10-30T06:21:58 (imported from GitLab)

Created by: stilvoid

Same thing here. Protect a branch, delete the same branch, protected branches page gets a 500 response.

By Administrator on 2012-11-07T10:18:49 (imported from GitLab project)

By Administrator on 2012-11-07T10:18:49 (imported from GitLab)

Created by: mkorich

Please fix.

By Administrator on 2012-11-07T18:25:53 (imported from GitLab project)

By Administrator on 2012-11-07T18:25:53 (imported from GitLab)

Created by: dzaporozhets

fixed. thank you guys for feedback and logs

By Administrator on 2012-12-03T11:22:40 (imported from GitLab project)

By Administrator on 2012-12-03T11:22:40 (imported from GitLab)

Created by: stilvoid

Nice one :)

By Administrator on 2012-12-03T11:26:02 (imported from GitLab project)

By Administrator on 2012-12-03T11:26:02 (imported from GitLab)