Skip to content
Snippets Groups Projects

Break up links with nested formating (rebased)

Created by: riyad

Breaks up "block links" to be simpler and contain less "structure" (i.e. HTML) so that the structure is outside and the links encapsulate only the text.

Rebased #1130. This is also in preparation for changes regarding #527 (closed).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: vsizov

    screenshots

    By Administrator on 2012-07-26T08:15:21 (imported from GitLab project)

    By Administrator on 2012-07-26T08:15:21 (imported from GitLab)

  • Created by: superbobry

    @vsizov politeness, maybe?

    By Administrator on 2012-07-26T10:10:37 (imported from GitLab project)

    By Administrator on 2012-07-26T10:10:37 (imported from GitLab)

  • Created by: riyad

    It looks absolutely te same. The only noticable changes are: links are only text or buttons. i.e. clicking in the empty area in the commits or issues lists will not trigger the link any more.

    By Administrator on 2012-07-26T12:33:11 (imported from GitLab project)

    By Administrator on 2012-07-26T12:33:11 (imported from GitLab)

  • Created by: vsizov

    @superbobry What do you want? You always try to talk back. How much work do you do for this project? I spent on this project 1 year from my life. What about you? I try to optimize my time and spend it time for gitlabhq. Next my answer will be rough.

    By Administrator on 2012-07-26T13:07:48 (imported from GitLab project)

    By Administrator on 2012-07-26T13:07:48 (imported from GitLab)

  • Created by: superbobry

    @vsizov Frankly, I don't see a connection between optimizing time and disrespecting your users, so I'm not sure if your answer explains any of the rude comments you guys post regularly on the issue tracker.

    By Administrator on 2012-07-26T13:22:29 (imported from GitLab project)

    By Administrator on 2012-07-26T13:22:29 (imported from GitLab)

  • Created by: si14

    @vsizov you can also try to visit him in person and beat the shit out of him. I'm quite sure that this would make everyone's life better.

    By Administrator on 2012-07-26T13:24:01 (imported from GitLab project)

    By Administrator on 2012-07-26T13:24:01 (imported from GitLab)

  • Created by: dzaporozhets

    @superbobry Seems like you try to provoke a gitlab team. Why?

    By Administrator on 2012-07-27T06:46:07 (imported from GitLab project)

    By Administrator on 2012-07-27T06:46:07 (imported from GitLab)

  • Created by: riyad

    now thst we are calm again ... can we come back to the MR at hand? ;)

    By Administrator on 2012-07-27T16:40:27 (imported from GitLab project)

    By Administrator on 2012-07-27T16:40:27 (imported from GitLab)

  • Created by: riyad

    I repeat: It looks absolutely te same.

    The only noticable changes are: links will only be text or buttons. i.e. clicking in the empty area in the commits or issues lists will not trigger the link any more.

    By Administrator on 2012-07-27T16:41:25 (imported from GitLab project)

    By Administrator on 2012-07-27T16:41:25 (imported from GitLab)

  • gitlab-qa-bot
24 24 - else
25 25 = image_tag "no_avatar.png", :class => "avatar"
26 26
27 = link_to project_issue_path(issue.project, issue) do
28 %p.row_title= truncate(issue.title, :length => 100)
27 %p= link_to truncate(issue.title, :length => 100), project_issue_path(issue.project, issue), :class => "row_title"
  • Created by: dzaporozhets

    why p without .row_title? It cause unnecessary top padding

    By Administrator on 2012-07-27T20:54:15 (imported from GitLab project)

    By Administrator on 2012-07-27T20:54:15 (imported from GitLab)

  • Created by: dzaporozhets

    btw Its not absolutely the same. Already pushed one fix & need 2 more

    By Administrator on 2012-07-27T21:04:56 (imported from GitLab project)

    By Administrator on 2012-07-27T21:04:56 (imported from GitLab)

  • Created by: dzaporozhets

    Anyway its a step forward ;)

    By Administrator on 2012-07-27T21:28:49 (imported from GitLab project)

    By Administrator on 2012-07-27T21:28:49 (imported from GitLab)

  • Please register or sign in to reply
    Loading