Gitlab flavored markdown
Created by: riyad
Allows use of Github Flavored Markdown to link to
- issues (#123 (closed))
- merge request (!123)
- commits (1234567)
- team members (@foo)
- snippets ($123)
in
- commit messages
- notes/comments/wall posts
- issues
- merge requests
- milestones
- wiki pages
and fulfills much of the promise of #527 (closed).
Please test this before merging and come back with any issues. The links are marked up nicely so individual styling can be applied. For now it will just show a tooltip with some info about the linked item when hovering over the link.
What is not included:
- linking to notes/attachments (let's say it's complicated)
- fancy styling (ideas and help appreciated, especially help)
- making it more discoverable and adding docs/help
- automated actions or notifications (this will be tough)
Merge request reports
Activity
Created by: riyad
and here is the screen shot ... but the changes are subtle. :)
By Administrator on 2012-08-02T02:38:11 (imported from GitLab project)
By Administrator on 2012-08-02T02:38:11 (imported from GitLab)
Created by: dzaporozhets
@Riyad I'm going to spend few hours for this today. I'll provide a feedback
By Administrator on 2012-08-04T07:00:06 (imported from GitLab project)
By Administrator on 2012-08-04T07:00:06 (imported from GitLab)
Created by: dzaporozhets
played with it. pretty good :)
Also we need:
- check there is no perfomance decrease
- make link in comment form with help popup containing gitlab markup examples
I'll continue review on next weekend. Or someone from gitlab core will do it earlier.
PS: Great work :)
By Administrator on 2012-08-05T08:40:23 (imported from GitLab project)
By Administrator on 2012-08-05T08:40:23 (imported from GitLab)
Created by: vsizov
First of all, I would like to thank you. There is a little problem http://i.imgur.com/ZG5dc.png Can you fix that?
By Administrator on 2012-08-05T16:12:09 (imported from GitLab project)
By Administrator on 2012-08-05T16:12:09 (imported from GitLab)
Created by: riyad
@randx how would you measure the performance impact? @vsizov I'll look into it :)
By Administrator on 2012-08-05T20:20:54 (imported from GitLab project)
By Administrator on 2012-08-05T20:20:54 (imported from GitLab)
Created by: riyad
I've merged with master and fixed the failing tests @vsizov was running into. It seems the @Project variable is not set in all circumstances (e.g. notification mails) which leads GFM to fail. It will now raise an exception if that is the case to make finding the error more obvious. Also I updated the notification mails to start using the GFM notation.
By Administrator on 2012-08-06T02:13:17 (imported from GitLab project)
By Administrator on 2012-08-06T02:13:17 (imported from GitLab)
Created by: dzaporozhets
@Riyad lets create a separate helper like GitalbFlavoredMarkdownHelper instead keeping all stuff in app herlper
By Administrator on 2012-08-07T09:24:43 (imported from GitLab project)
By Administrator on 2012-08-07T09:24:43 (imported from GitLab)
Created by: dzaporozhets
lets merge it. tired to wait :)
@Riyad thank you!!!
By Administrator on 2012-08-07T19:17:05 (imported from GitLab project)
By Administrator on 2012-08-07T19:17:05 (imported from GitLab)
Created by: optikfluffel
+1
On 07.08.2012, at 21:17, Dmitriy Zaporozhets notifications@github.com wrote:
lets merge it. tired to wait :)
@Riyad thank you!!!
— Reply to this email directly or view it on GitHub.
By Administrator on 2012-08-07T19:27:49 (imported from GitLab project)
By Administrator on 2012-08-07T19:27:49 (imported from GitLab)
Created by: dzaporozhets
Help page added 34ba4e13
By Administrator on 2012-08-07T19:39:33 (imported from GitLab project)
By Administrator on 2012-08-07T19:39:33 (imported from GitLab)
Created by: vrybas
@Riyad What do you mean by "snippets"? The Gists? Can you please attach snippet in your reply. I can't get it working.
By Administrator on 2012-10-02T08:23:16 (imported from GitLab project)
By Administrator on 2012-10-02T08:23:16 (imported from GitLab)
Created by: riyad
@vrybas GitHub calls them Gists. In GitLab they are called "Snippets". You can access them from your project dashboard from the second row of tabs.
Do you see the "Snippets" tab?
By Administrator on 2012-10-03T01:04:34 (imported from GitLab project)
By Administrator on 2012-10-03T01:04:34 (imported from GitLab)
Created by: vrybas
@Riyad got it now, thanks
By Administrator on 2012-10-03T03:08:24 (imported from GitLab project)
By Administrator on 2012-10-03T03:08:24 (imported from GitLab)
