Skip to content
Snippets Groups Projects

fix notify_team on wall

Merged fix notify_team on wall
github/fork/jojosch/fix-notify-notes into master
Merged gitlab-qa-bot requested to merge github/fork/jojosch/fix-notify-notes into master

Created by: jojosch

see #2212 (closed)

if a comment on the wall was posted, inside notify_team the var noteable_type was empty, so the var notify_method was = note__email and no email was sent.

with this fix noteable_type will be "Wall" if note.noteable_type is empty or nil

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
app/observers/note_observer.rb
21 21 # Notifies the whole team except the author of note
22 22 def notify_team(note)
23 23 # Note: wall posts are not "attached" to anything, so fall back to "Wall"
24 noteable_type = note.noteable_type || "Wall"
24 noteable_type = note.noteable_type.presence || "Wall"
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    note.noteable_type.blank?

    By Administrator on 2012-12-07T18:36:25 (imported from GitLab project)

    By Administrator on 2012-12-07T18:36:25 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit eededdd4
    • app/observers/note_observer.rb
    21 21 # Notifies the whole team except the author of note
    22 22 def notify_team(note)
    23 23 # Note: wall posts are not "attached" to anything, so fall back to "Wall"
    24 noteable_type = note.noteable_type || "Wall"
    24 noteable_type = note.noteable_type.presence || "Wall"
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dzaporozhets

      noteable_type = note.noteable_type.present? ? note.noteable_type : "Wall"

      By Administrator on 2012-12-07T18:36:25 (imported from GitLab project)

      By Administrator on 2012-12-07T18:36:25 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    Thank you

    By Administrator on 2012-12-07T20:52:31 (imported from GitLab project)

    By Administrator on 2012-12-07T20:52:31 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: sriharshav

    Thanks for this fix. Can't wait till 4.0 will pick this now.

    By Administrator on 2012-12-08T07:25:02 (imported from GitLab project)

    By Administrator on 2012-12-08T07:25:02 (imported from GitLab)

    • Please register or sign in to reply