Skip to content
Snippets Groups Projects

Minor: Change html input type to "email" on sign-in view

Merged gitlab-qa-bot requested to merge github/fork/alexleutgoeb/patch-1 into master

Created by: alexleutgoeb

As long as the username is the user's email address it makes sense to use input="email" helper for the email field. This allows HTML5 capable (mobile) devices to bring up an email input keyboard instead of the default one.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: NARKOZ

    Can we also add autofocus and required attributes?

    By Administrator on 2012-12-11T10:32:12 (imported from GitLab project)

    By Administrator on 2012-12-11T10:32:12 (imported from GitLab)

  • Created by: alexleutgoeb

    "autofocus" is a good idea, "required" however frames the input fields in red which is not very beautiful imho. I guess there is no style defined for the [required] selector atm?

    Screen Shot 2012-12-11 at 11 44 07

    By Administrator on 2012-12-11T10:47:49 (imported from GitLab project)

    By Administrator on 2012-12-11T10:47:49 (imported from GitLab)

  • Created by: dzaporozhets

    i'm not sure we need require for login form. Also this red frame makes me sad :)

    By Administrator on 2012-12-11T10:53:11 (imported from GitLab project)

    By Administrator on 2012-12-11T10:53:11 (imported from GitLab)

  • Created by: NARKOZ

    Yes, just autofocus: true will be enough.

    I guess there is no style defined for the [required] selector atm?

    I believe it's defined in bootstrap.

    By Administrator on 2012-12-11T11:14:38 (imported from GitLab project)

    By Administrator on 2012-12-11T11:14:38 (imported from GitLab)

  • Created by: alexleutgoeb

    So I guess autofocus: autofocus is fine too? ;-) Or do you have some convention for boolean attributes?

    Not sure why the latest travis build failed with Project Issues :: I submit new unassigned issue :: Given I click link "500 error on profile", never touched a file in there...

    By Administrator on 2012-12-11T14:21:59 (imported from GitLab project)

    By Administrator on 2012-12-11T14:21:59 (imported from GitLab)

  • Created by: riyad

    +1 for autofocus

    By Administrator on 2012-12-11T15:11:26 (imported from GitLab project)

    By Administrator on 2012-12-11T15:11:26 (imported from GitLab)

  • Created by: dzaporozhets

    thank you

    By Administrator on 2012-12-12T12:18:01 (imported from GitLab project)

    By Administrator on 2012-12-12T12:18:01 (imported from GitLab)

Please register or sign in to reply
Loading