Issues bulk update

Created by: AlexDenisov

Added few specs and cleanup a bit.

app/contexts/issues/bulk_update_context.rb

@@ -8,6 +8,16 @@ module Issues
       assignee_id  = update_data[:assignee_id]
       status       = update_data[:status]
+      new_state = nil
+
+      if status.present?
+        if status == 'closed'
+          new_state = :close
+        else
+          new_state = :reopen
+        end
+      end
+
       opts = {}
       opts[:milestone_id] = milestone_id if milestone_id.present?
       opts[:assignee_id] = assignee_id if assignee_id.present?
@@ -17,14 +27,7 @@ module Issues
       issues.each do |issue|
         issue.update_attributes(opts)
-
-        if status.present?
-          if status == 'closed'
-            issue.close
-          else
-            issue.reopen
-          end
-        end
+        issue.send new_state if new_state
       end
       {

[gitlab-qa-bot]

Created by: dzaporozhets

what if I want just to update assignee or milestone? status will be blank in this case

By Administrator on 2013-05-16T10:32:53 (imported from GitLab project)

By Administrator on 2013-05-16T10:32:53 (imported from GitLab)

[gitlab-qa-bot]

Created by: AlexDenisov

Sorry, that's my fault. I'll revert this cleanup and add few more tests for those cases.

By Administrator on 2013-05-16T10:32:53 (imported from GitLab project)

By Administrator on 2013-05-16T10:32:53 (imported from GitLab)